[no-relnotes] Use reusable workflows for CI #246
Conversation
.github/workflows/image.yaml
Outdated
| @@ -56,8 +45,10 @@ jobs: | |||
| password: ${{ secrets.GITHUB_TOKEN }} | |||
| - name: Build image | |||
| env: | |||
| IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/k8s-dra-driver | |||
| VERSION: ${COMMIT_SHORT_SHA} | |||
| IMAGE_NAME: ghcr.io/nvidia/k8s-device-plugin | |||
There was a problem hiding this comment.
My bad, I was testing the workflows and forgot to edit this bit, it is now fixed
.github/workflows/golang.yaml
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2024 NVIDIA CORPORATION | |||
| # Copyright 2024-2025 NVIDIA CORPORATION | |||
There was a problem hiding this comment.
Just keep the year the file was originally created
|
Rebased, ready for review |
.github/workflows/image.yaml
Outdated
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| with: | ||
| image: tonistiigi/binfmt:master |
There was a problem hiding this comment.
I believe this needs to match: https://github.com/NVIDIA/k8s-samples/blob/a0d87c7bc5f572d13da40596a6394adb3ad1df17/.github/workflows/image.yaml#L57
There was a problem hiding this comment.
thank you, done
.github/workflows/image.yaml
Outdated
| @@ -56,8 +45,10 @@ jobs: | |||
| password: ${{ secrets.GITHUB_TOKEN }} | |||
| - name: Build image | |||
| env: | |||
| IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/k8s-dra-driver-gpu | |||
| VERSION: ${COMMIT_SHORT_SHA} | |||
| IMAGE_NAME: ghcr.io/nvidia/k8s-dra-driver | |||
There was a problem hiding this comment.
Is this:
| IMAGE_NAME: ghcr.io/nvidia/k8s-dra-driver | |
| IMAGE_NAME: ghcr.io/nvidia/k8s-dra-driver-gpu |
There was a problem hiding this comment.
thank you, done
|
/ok to test |
| secrets: inherit | ||
| with: | ||
| version: ${{ needs.basic.outputs.version }} | ||
| build_multi_arch_images: ${{ github.ref_name == 'main' || startsWith(github.ref_name, 'release-') }} |
There was a problem hiding this comment.
Question (not a blocker): given that we've optimized the multi-arch builds in this repo to use GOARCH, should we not just drop this or set it to true all the time?
.github/workflows/image.yaml
Outdated
| build_multi_arch_images: | ||
| required: true | ||
| type: string |
There was a problem hiding this comment.
| build_multi_arch_images: | |
| required: true | |
| type: string | |
| build_multi_arch_images: | |
| required: false | |
| type: string | |
| default: true |
This commit introduces the following changes to the CI structure. A more agressive split of the CI steps to reusable workflows. We now have the following high-level workflows: - A set of basic checks that are run on PR and can be invoked from a workflow - A full ci pipeline that is run on push to main and release-* branches (as well as PR copy bot branches) - A standalone definition for CodeQL Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Changes adopted, thanks for the suggestions |
This commit introduces the following changes to the CI structure. A more agressive split of the CI steps to reusable workflows. We now have the following high-level workflows: