-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to work with kubernetes 1.32 #218
Conversation
be656d3
to
bbc913d
Compare
@@ -48,7 +50,7 @@ func NewDriver(ctx context.Context, config *Config) (*driver, error) { | |||
|
|||
plugin, err := kubeletplugin.Start( | |||
ctx, | |||
driver, | |||
[]any{driver}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klueska why is this changed to a slice?
That's how Patrick changed the API to be able to support both v1alpha4 drivers and v1beta1 drivers simultaneously (if desired). |
Signed-off-by: Kevin Klues <[email protected]>
Signed-off-by: Kevin Klues <[email protected]>
@klueska Hi, I noticed that you mentioned the appeal earlier. |
Detail environment:
Modified gpu-test4.yaml to MIG configuration supported by GPU
Expected it to automatically configure MIG, but it didn't. |
It is not. Once this KEP is implemented it will be supported again: Unfortunately, we ran out of time in 1.32 to build the implementation. It should be done for 1.33 (as an alpha feature). |
No description provided.