Skip to content

Commit

Permalink
Remove unnused setting in daemon claim config
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Klues <[email protected]>
  • Loading branch information
klueska committed Mar 10, 2025
1 parent 670f965 commit 41fe1cb
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions api/nvidia.com/resource/v1beta1/computedomainconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ func (c *ComputeDomainChannelConfig) Validate() error {
// ComputeDomainDaemonConfig holds the set of parameters for configuring an ComputeDomainDaemon.
type ComputeDomainDaemonConfig struct {
metav1.TypeMeta `json:",inline"`
NumNodes int `json:"numNodes"`
DomainID string `json:"domainID"`
}

Expand All @@ -79,9 +78,6 @@ func (c *ComputeDomainDaemonConfig) Normalize() error {

// Validate ensures that ComputeDomainDaemonConfig has a valid set of values.
func (c *ComputeDomainDaemonConfig) Validate() error {
if c.NumNodes <= 0 {
return fmt.Errorf("numNodes must be greater than or equal to 1")
}
if c.DomainID == "" {
return fmt.Errorf("domainID cannot be empty")
}
Expand Down
1 change: 0 additions & 1 deletion cmd/compute-domain-controller/resourceclaimtemplate.go
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ func (m *DaemonSetResourceClaimTemplateManager) Create(ctx context.Context, name
}

daemonConfig := nvapi.DefaultComputeDomainDaemonConfig()
daemonConfig.NumNodes = cd.Spec.NumNodes
daemonConfig.DomainID = string(cd.UID)

templateData := ResourceClaimTemplateTemplateData{
Expand Down
1 change: 0 additions & 1 deletion templates/compute-domain-daemon-claim-template.tmpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@ spec:
parameters:
apiVersion: {{ .DaemonConfig.APIVersion }}
kind: {{ .DaemonConfig.Kind }}
numNodes: {{ .DaemonConfig.NumNodes }}
domainID: {{ .DaemonConfig.DomainID }}

0 comments on commit 41fe1cb

Please sign in to comment.