Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use constant variables in Reconciled #1170

Merged
merged 1 commit into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/nvidiadriver_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func (r *NVIDIADriverReconciler) Reconcile(ctx context.Context, req ctrl.Request
return reconcile.Result{RequeueAfter: time.Second * 5}, nil
}

if condErr = r.conditionUpdater.SetConditionsReady(ctx, instance, "Reconciled", "All resources have been successfully reconciled"); condErr != nil {
if condErr = r.conditionUpdater.SetConditionsReady(ctx, instance, conditions.Reconciled, "All resources have been successfully reconciled"); condErr != nil {
return ctrl.Result{}, condErr
}
return reconcile.Result{}, nil
Expand Down
2 changes: 1 addition & 1 deletion internal/conditions/conditions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func TestConditionsUpdater_SetConditionsReady(t *testing.T) {
Reason: "Ready",
}

err := u.SetConditionsReady(context.Background(), driver, "Reconciled", "All resources are successfully reconciled")
err := u.SetConditionsReady(context.Background(), driver, Reconciled, "All resources are successfully reconciled")
assert.NoError(t, err)

instance := &nvidiav1alpha1.NVIDIADriver{}
Expand Down
Loading