Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Added golangci configuration and formater to the makefile #300

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

nvvfedorov
Copy link
Collaborator

  • We need to have the ability to control golangci-lint execution timeout.
  • Added explicit golangci-lint configuration.
  • The golangci-lint now enforces rules only in a new code.
  • Formated the file that was in the past not formatted.

Signed-off-by: Vadym Fedorov <[email protected]>
@nvvfedorov nvvfedorov self-assigned this Mar 21, 2024
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@rohit-arora-dev rohit-arora-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvvfedorov

/LGTM

@nvvfedorov nvvfedorov merged commit 1c79aca into main Apr 2, 2024
1 check passed
@nvvfedorov nvvfedorov deleted the chore-changes-in-golangci-lint branch April 2, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants