Accept extensions other than .cpp in nvq++

[bebora]

Problem description

I took a look at nvq++ after reading #2512 and found the culprit:

file=$(basename -s .cc -s .cpp $i)

nvq++ seems to be written to already allow .cc files. However, basename only honors the latest -s option when multiple ones are provided:

$ basename -s .py abc.py
abc
$ basename -s .py -s .txt abc.py
abc.py
$ basename -s .txt -s .py abc.py
abc

Assume to be compiling a file named ghz.cc; during the compilation steps the following command would be run by nvq++ (simplified for clarity):

cudaq-quake --emit-llvm-file ghz.cc -o ghz.cc.qke

This command will create two files: ghz.cc.qke and ghz.ll. Note that the LLVM IR file does not have the ".cc" part.
The compilation will fail due to the unexpected filename and that specific .ll file will be kept as a leftover.

Proposed solution

basename can still be used to get a "stem.suffix" string. The suffix can then be removed using Bash Parameter Substitution.
I also added the support for .cxx and .c++ as these are common enough C++ source file extensions.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[schweitzpgi]

This is closer, but will fail if the source file has more than one . in the name. (It removes everything after the first ..)

Maybe let's try writing a simple function to do this instead. Something like this ought to catch the 4 cases precisely.

function remove_suffix {
  case $1 in
  *.cpp) rv=`basename -s .cpp $i` ;;
  ...
  esac
  $rv
}

[bebora]

Nice catch.
The following line should only remove the part after the last .:

file=${file_with_suffix%.*}

Would you prefer this little modification or the custom function approach?