-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure uccsd compiles for quantum devices #2458
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…x-for-demo Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
…x-for-demo Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…x-for-demo Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
I, Anna Gringauze <agringauze@nvidia.com>, hereby add my Signed-off-by to this commit: ae35d16 Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the idea of making the patterns reside in files other than the pass where they are applied. That's not been the practice. So I think we should merge them back.
The exception to this general rule is when patterns are shared in multiple passes, which these are not AFAICT. Instead of block copying the same pattern in 2 or more different passes and where they will become hopelessly out of synch with one another, we want to put the pattern in an include file (foo.inc
) and include that file in the n passes where it is needed. The patterns in LowerToCFG for IfOp is such a case, since it will be the same rewrite in LowerToCFG (indiscriminate) and in the canonicalization pattern you want to add (selected only when the condition is constant).
…x-for-demo Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
…op-unroll-additional-opts Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…grin/cuda-quantum into fix-for-demo Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…x-for-demo Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
…x-for-demo Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Description
Make sure
cudaq.uccsd
compiles for quantum devices.Details
uccsd
: Update to not contain nested arraysBaseRemoteRestQPU.h
: runmemtoreg
before the first cc-loop-unroll pass (helps python's argument passing logic)classical-optimization-pipeline
to replace a bunch of existing passesRequires: NVIDIA/cudaqx#64Requires: #2570Requires: #2571Requires: #2572Requires: #2573Requires: #2591Requires: #2605
Closes:#2357