[cmake] Fix double installation of nvq++ libs. #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR disables MLIR's installation of our optimizer's libs. We do it ourselves. Fixing this problem is particularly relevant our python wheels: The issue is aggravated there because the manylinux image has an enviroment that favors libraries to be installed in `lib64` prefix. MLIR's build system honors that; our's don't, and thus we ship wheels that have these libs installed twice, one in `lib` and another in `lib64`. The issue that these libs don't need to be part of the wheels will be addressed in a later commit. Signed-off-by: boschmitt <[email protected]>
|
Do these have to be installed in |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Currently yes. The |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables MLIR's installation of our optimizer's libs. We do it ourselves. Fixing this problem is particularly relevant our python wheels: The issue is aggravated there because the manylinux image has an enviroment that favors libraries to be installed in
lib64prefix. MLIR's build system honors that; our's don't, and thus we ship wheels that have these libs installed twice, one inliband another inlib64.The issue that these libs don't need to be part of the wheels will be addressed in a later commit.