Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Operators and Integration with cudensitymat #2407

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

[WIP] Operators and Integration with cudensitymat #2407

wants to merge 33 commits into from

Conversation

sacpis
Copy link
Collaborator

@sacpis sacpis commented Nov 25, 2024

Adding missing operations in operators

Co-authored with @anthony-santana.

@sacpis sacpis requested review from bettinaheim and 1tnguyen and removed request for bettinaheim and 1tnguyen November 25, 2024 04:48
amccaskey
amccaskey reviewed Nov 25, 2024
View reviewed changes
runtime/cudaq/dynamics/operators.h Outdated
@@ -0,0 +1,495 @@
/*******************************************************************************
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited for this feature. I appreciate all the work you two have done on this one. One thought here -

Operators are more broad that dynamics. Ideally this would be part of a cudaq/operators.h public header. Did we ever finish the language review for this feature? Would be good to get a meeting scheduled.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 0f6496d to 791fb25 Compare December 19, 2024 19:50
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 2c1f0a2 to 92c922f Compare January 8, 2025 22:27
@sacpis sacpis closed this Jan 9, 2025
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 92c922f to da44eda Compare January 9, 2025 17:23
@sacpis sacpis temporarily deployed to ghcr-deployment January 9, 2025 17:24 — with GitHub Actions Inactive
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2407.
84b9b79
@sacpis sacpis temporarily deployed to ghcr-deployment January 9, 2025 17:24 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@cuda-quantum-bot
Docs preview for PR #2407.
1a2770b
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:08 — with GitHub Actions Inactive
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:09 — with GitHub Actions Inactive
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:09 — with GitHub Actions Inactive
sacpis added 29 commits January 29, 2025 08:29
@sacpis
adding base_operators interface
bdbcf7b 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
keeping degrees to match the current implementation
84a7827 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
adding base integrator and time stepper
f11612b 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Adding base test cases for Runge-Kutta stepper and integrator
4912d01 
* Removing base_operator class, as operator_sum will act as a base class

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Adding helpers functionlity
01756b4 
	* Aggregating parameters
	* Extracting documentation
	* Extracting positional and keyword arguments
	* Generating all quantum states for given degrees and dimensions
	* Permuting a given matrix
	* Canonicalizing degrees
* Adding test cases for the above functions
* Formatting

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Formatting
ff1a730 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding evolution API header
499835e 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Formatting
abb481e 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Replacing Eigen::MatrixXcd with matrix_2
a3f8e7a 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Adding Rydberg hamiltonian operator
d7850ab 
* Adding unitests for Rydberg hamiltonian operator
* Making evaluate function in scalar_operator const

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding interface for cudm_helpers
132aeb4 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Changing matrix to operator_sum
9df00af 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
cudm_helpers implementation
482b971 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Formatting
34a347f 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Adding macro for handling error
f6ec93c 
* Using CUDA_C_64F data type for complex

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding MACRO for error handling
12f5a5e 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Fixing convert_to_cudensitymat_operator as per the cudensitymat APIs
9dc10c9 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Updating CMakeLists and unittests
018edd0 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Adding vector of cudensitymatElementaryOperator_t to store and destroy
7de3eb7 
  the cudensitymatElementaryOperator_t
* Fetching subspace_extents using elementary_op degrees
* Adding a vector with correct action duality

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Refactoring the code
7047cf7 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Fixing the matrix in the unittest and other code in compute_lindblad …
fc075b9 
…apart for temp vector

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding cudm_state with unittests
5c56c96 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Addign few more unit tests for cudm_state
e5e1fa3 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding an enum with initial quantum state and initilize_state based o…
8b5569b 
…n InitialStateArgT

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Fixing spelling
ee4988c 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
* Renaming cudm_mat_state -> cudm_state
ae2d84a 
* Adding create_initial_state method to create initial state based on
  the passed InitialStateArgT

Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Exposing state's rawData to be used in the stepper
d109072 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Adding cudm_time_stepper with unittests
1cac3ef 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Refactoring time_stepper compute method to align with cuquantum workflow
337fa80 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 5169445 to 337fa80 Compare January 30, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1tnguyen 1tnguyen 1tnguyen left review comments

@amccaskey amccaskey amccaskey left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sacpis @amccaskey @1tnguyen @boschmitt @bettinaheim @anthony-santana @cuda-quantum-bot