Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 21, 2025

This PR creates new cuda-bindings release note files to document missing improvements that were part of milestone 14 but were not included in the release notes, and ensures they are properly linked in the Sphinx documentation system.

Problem

Several important PRs merged as part of milestone 14 were missing from the cuda-bindings release notes:

These improvements significantly enhance the installation experience but were not reflected in the release documentation. Additionally, the new release note files needed to be properly linked in the Sphinx documentation system for rendering.

Solution

Created new release note files following the proper naming convention for future releases:

  • 12.9.X-notes.rst - Documents the automatic CUDA library path detection feature for the next 12.9 series release
  • 13.X.Y-notes.rst - Documents the same feature for the next 13.x series release

Both files have been added to the Sphinx toctree in release.rst to ensure proper documentation rendering. The new files highlight the key improvement: automatic CUDA library path detection based on CUDA_HOME, which eliminates the need to manually set LIBRARY_PATH environment variables for installation.

Impact

Users will have accurate and complete release documentation for future versions that reflects all the installation improvements delivered in milestone 14. The documentation now properly informs users about the elimination of manual LIBRARY_PATH setup requirements and improved installation robustness through automatic CUDA library detection. The files are now properly integrated into the documentation build system and will be rendered by Sphinx.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor

copy-pr-bot bot commented Aug 21, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Copilot Copilot AI changed the title [WIP] There are a few cuda-bindings PR that are merged recently and part of this milestone https://github.com/NVIDIA/cuda-python/milestone/14, but they missed release notes. Could you make sure the cuda-bindings release note is up to date? Update cuda-bindings release notes for missing milestone 14 improvements Aug 21, 2025
@Copilot Copilot AI requested a review from leofang August 21, 2025 18:25
Copilot finished work on behalf of leofang August 21, 2025 18:25
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in CCCL Aug 21, 2025
@Copilot Copilot AI changed the title Update cuda-bindings release notes for missing milestone 14 improvements Create new cuda-bindings release note files for missing milestone 14 improvements Aug 21, 2025
@Copilot Copilot AI requested a review from leofang August 21, 2025 18:34
Copilot finished work on behalf of leofang August 21, 2025 18:34
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @copilot. One last thing, the new rst files need to be linked in cuda_bindings/docs/source/release.rst (or .md, I forget) so that they are rendered by Sphinx. You know what to do 🙂

Copy link
Contributor Author

Copilot AI commented Aug 21, 2025

Thanks, @copilot. One last thing, the new rst files need to be linked in cuda_bindings/docs/source/release.rst (or .md, I forget) so that they are rendered by Sphinx. You know what to do 🙂

Added both new release note files to the Sphinx toctree in release.rst. The files 12.9.X-notes.rst and 13.X.Y-notes.rst are now properly linked and will be rendered by the documentation system. Changes made in commit cc26eba.

@Copilot Copilot AI changed the title Create new cuda-bindings release note files for missing milestone 14 improvements Create new cuda-bindings release note files for missing milestone 14 improvements and link them in documentation Aug 21, 2025
@leofang leofang marked this pull request as ready for review August 21, 2025 18:39
@Copilot Copilot AI requested a review from leofang August 21, 2025 18:39
Copilot finished work on behalf of leofang August 21, 2025 18:39
@leofang leofang added cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P0 High priority - Must do! labels Aug 21, 2025
@leofang leofang added this to the cuda-python parking lot milestone Aug 21, 2025
@leofang leofang requested a review from Andy-Jost August 21, 2025 21:48
@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Aug 21, 2025
@leofang leofang merged commit ce80737 into main Aug 21, 2025
4 checks passed
@leofang leofang deleted the copilot/fix-b38a3e03-9f5c-46f9-8f2b-adde83e179fb branch August 21, 2025 22:47
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Aug 21, 2025
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P0 High priority - Must do!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants