Skip to content

Add cufile bindings #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

sourabgupta3
Copy link

@sourabgupta3 sourabgupta3 commented Jun 6, 2025

Description

closes #585

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Contributor

copy-pr-bot bot commented Jun 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang self-requested a review June 6, 2025 14:22
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jun 6, 2025
@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.bindings Everything related to the cuda.bindings module labels Jun 6, 2025
@leofang leofang changed the title Draft: Add cufile bindings(Not building currently) Draft: Add cufile bindings Jun 6, 2025
@leofang
Copy link
Member

leofang commented Jun 6, 2025

/ok to test 01990c0

@leofang
Copy link
Member

leofang commented Jun 6, 2025

@sourabgupta3 there are some CI works I'll need to address later, but please proceed to test it locally. It builds on Linux now.

@leofang
Copy link
Member

leofang commented Jun 18, 2025

/ok to test 5fed951

@leofang
Copy link
Member

leofang commented Jun 22, 2025

/ok to test 70837af

@leofang
Copy link
Member

leofang commented Jun 22, 2025

/ok to test 571f60b

@leofang
Copy link
Member

leofang commented Jun 22, 2025

/ok to test 77dbde4

@leofang
Copy link
Member

leofang commented Jun 22, 2025

/ok to test a3d62f2

@leofang
Copy link
Member

leofang commented Jun 23, 2025

/ok to test 5ff2f4e

@leofang
Copy link
Member

leofang commented Jul 2, 2025

/ok to test fac4100

Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some quick comments. I haven't gone through the whole test suite yet.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in CCCL Jul 2, 2025
@sourabgupta3
Copy link
Author

/ok to test fbb4cdb

@leofang
Copy link
Member

leofang commented Jul 3, 2025

The CI was not run because the commit cannot be hyperlinked. Must be a raw text. (GitHub does render commit texts to be clickable, so it's hard by eye-balling it, but it does make a difference to the copy-pr-bot...)

@leofang
Copy link
Member

leofang commented Jul 3, 2025

/ok to test dae5893

@leofang
Copy link
Member

leofang commented Jul 3, 2025

/ok to test f469124

@leofang
Copy link
Member

leofang commented Jul 3, 2025

/ok to test eaa8d6b

@leofang leofang changed the title Draft: Add cufile bindings Add cufile bindings Jul 3, 2025
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is all green!

@@ -103,6 +104,7 @@
"numpy": ("https://numpy.org/doc/stable/", None),
"nvvm": ("https://docs.nvidia.com/cuda/libnvvm-api/", None),
"nvjitlink": ("https://docs.nvidia.com/cuda/nvjitlink/", None),
"cufile": ("https://docs.nvidia.com/gpudirect-storage/api-reference-guide/", None),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, this currently does not work, but it's not a blocker for merging.

@github-project-automation github-project-automation bot moved this from In Progress to In Review in CCCL Jul 3, 2025
return version


cpdef get_parameter_size_t(int param, intptr_t value):
Copy link
Member

@leofang leofang Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this more, we probably could generate a more user friendly signature?

Suggested change
cpdef get_parameter_size_t(int param, intptr_t value):
cpdef size_t get_parameter_size_t(int param):

which would return a Python int. WDYT? (Same for the other two getter APIs.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module feature New feature or request P0 High priority - Must do!
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Add cuFile bindings
2 participants