Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change __cuda_stream__ from attribute to method #389

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Change __cuda_stream__ from attribute to method #389

merged 8 commits into from
Jan 15, 2025

Conversation

NaderAlAwar
Copy link
Contributor

Close #348

@NaderAlAwar NaderAlAwar requested a review from leofang January 13, 2025 16:12
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 13, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang
Copy link
Member

leofang commented Jan 13, 2025

Thanks, Nader! Could you also update cuda_core/examples/simple_multi_gpu_example.py and add a new file cuda_core/docs/source/release/0.2.0-notes.rst (btw we are shifting to full Sphinx #318) to note about this breaking change?

@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels Jan 13, 2025
@leofang
Copy link
Member

leofang commented Jan 13, 2025

/ok to test

leofang
leofang previously approved these changes Jan 13, 2025
View reviewed changes
cuda_core/cuda/core/experimental/_stream.py Outdated Show resolved Hide resolved
@NaderAlAwar NaderAlAwar requested a review from leofang January 14, 2025 17:00
@leofang
Copy link
Member

leofang commented Jan 15, 2025

@shwina we already have a pre-commit ci set up? ❤️

@shwina
Copy link
Contributor

shwina commented Jan 15, 2025

@shwina we already have a pre-commit ci set up? ❤️

Yup :) #396 tightens up the config.

shwina
shwina approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shwina
Copy link
Contributor

shwina commented Jan 15, 2025

/ok to test

@leofang
Copy link
Member

leofang commented Jan 15, 2025

oh now that we have job status checks we can turn on the auto merge feature now, let me set it up

@leofang leofang enabled auto-merge January 15, 2025 16:09
@leofang
Copy link
Member

leofang commented Jan 15, 2025

Auto merge enabled! Thanks, Nader/Ashwin!

@leofang leofang merged commit 4eee527 into NVIDIA:main Jan 15, 2025
79 checks passed
@github-actions GitHub Actions
Copy link

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

@shwina shwina shwina approved these changes

Assignees

@NaderAlAwar NaderAlAwar

Labels
breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 3
Development

Successfully merging this pull request may close these issues.

RFC: Change __cuda_stream__ from class attribute to method
3 participants
@NaderAlAwar @leofang @shwina