Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation of getPtr to overview.md #375

Merged
merged 10 commits into from
Jan 16, 2025

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Jan 10, 2025

close #126

Copy link
Contributor

copy-pr-bot bot commented Jan 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work ksimpson-work self-assigned this Jan 10, 2025
@ksimpson-work ksimpson-work added the cuda.bindings Everything related to the cuda.bindings module label Jan 10, 2025
@ksimpson-work ksimpson-work marked this pull request as ready for review January 10, 2025 21:17
@leofang leofang added documentation Improvements or additions to documentation P1 Medium priority - Should do labels Jan 12, 2025
@ksimpson-work
Copy link
Contributor Author

/ok to test

cuda_bindings/docs/source/overview.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/overview.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/overview.md Outdated Show resolved Hide resolved
@ksimpson-work ksimpson-work requested a review from leofang January 14, 2025 17:31
@leofang
Copy link
Member

leofang commented Jan 15, 2025

Please check out commit 8f79ed0, thanks!

@ksimpson-work
Copy link
Contributor Author

lgtm thanks

@leofang
Copy link
Member

leofang commented Jan 15, 2025

/ok to test

@leofang leofang enabled auto-merge January 15, 2025 19:40
@ksimpson-work
Copy link
Contributor Author

/ok to test

@leofang leofang merged commit 30a97d9 into NVIDIA:main Jan 16, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P1 Medium priority - Should do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to get addresses of the underlying C objects from the low-level object bindings
3 participants