fix updating nodes states #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
requested changes
May 22, 2024
There was a problem hiding this comment.
Could you please update
https://github.com/NVIDIA/cloudai/blob/main/tests/test_slurm_system.py
as well, so that we can understand which cases were not covered and are now covered?
TaekyungHeo
requested changes
May 23, 2024
|
Please fix failing CI pipelines as well. |
jeffnvidia
force-pushed
the
fix_node_fetch
branch
3 times, most recently
from
df011de to
ffbaea4
Compare
amaslenn
requested changes
May 23, 2024
jeffnvidia
force-pushed
the
fix_node_fetch
branch
9 times, most recently
from
6b5912d to
744d6c8
Compare
amaslenn
requested changes
May 27, 2024
jeffnvidia
force-pushed
the
fix_node_fetch
branch
2 times, most recently
from
3495f69 to
8415b33
Compare
amaslenn
requested changes
May 28, 2024
jeffnvidia
force-pushed
the
fix_node_fetch
branch
from
8415b33 to
903d83e
Compare
amaslenn
reviewed
May 29, 2024
amaslenn
approved these changes
May 29, 2024
TaekyungHeo
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on main
This PR fixes a bug : cloudAI wasnt able to correctly access the state of the nodes (IDLE, ALLOCATED ...)
fixed the parse_sinfo_output function
Test Plan
CI
2.1 Slurm command generation
$ cloudaix --mode run --system_config_path conf/v0.6/general/system/israel_1.toml --test_scenario_path conf/v0.6/general/test_scenario/llama/llama.toml
Additional Notes