use official online container #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffnvidia
force-pushed
the
use_online_containe_for_NeMo
branch
from
1c0f103 to
cb937ef
Compare
|
Needs PR template populated. |
|
Pl rebase directly on main. |
It was based on another PR of mine so that everything can be merged together |
jeffnvidia
force-pushed
the
use_online_containe_for_NeMo
branch
3 times, most recently
from
762005b to
5a4aefb
Compare
jeffnvidia
force-pushed
the
use_online_containe_for_NeMo
branch
from
5a4aefb to
edbdf6a
Compare
amaslenn
requested changes
May 23, 2024
jeffnvidia
force-pushed
the
use_online_containe_for_NeMo
branch
from
edbdf6a to
1525b55
Compare
jeffnvidia
force-pushed
the
use_online_containe_for_NeMo
branch
from
1525b55 to
b610739
Compare
amaslenn
approved these changes
May 30, 2024
|
@srinivas212 @TaekyungHeo please merge? was tested completlely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on PR 31
This MR is for using the official latest NeMo version
Test Plan
Test by @amaslenn
CI
Test by @jeffnvidia
2.1 Slurm command generation
$ cloudaix --mode run --system_config_path conf/v0.6/general/system/israel_1.toml --test_scenario_path conf/v0.6/general/test_scenario/llama/llama.toml
Additional Notes