-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bugs in K8s System Class Introduced During the Adoption of Pydantic #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
force-pushed
the
k8s-bug-fix
branch
3 times, most recently
from
September 17, 2024 14:19
506380d
to
30e31b6
Compare
TaekyungHeo
requested review from
amaslenn,
artemry-nv,
srivatsankrishnan and
srinivas212
September 17, 2024 14:19
TaekyungHeo
force-pushed
the
k8s-bug-fix
branch
from
September 17, 2024 14:26
30e31b6
to
db6f417
Compare
amaslenn
reviewed
Sep 17, 2024
Co-authored-by: Andrei Maslennikov <[email protected]>
srivatsankrishnan
previously approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Andrei Maslennikov <[email protected]>
amaslenn
reviewed
Sep 17, 2024
amaslenn
requested changes
Sep 18, 2024
Co-authored-by: Andrei Maslennikov <[email protected]>
amaslenn
requested changes
Sep 18, 2024
Co-authored-by: Andrei Maslennikov <[email protected]>
amaslenn
requested changes
Sep 19, 2024
Co-authored-by: Andrei Maslennikov <[email protected]>
Co-authored-by: Andrei Maslennikov <[email protected]>
amaslenn
previously approved these changes
Sep 19, 2024
Co-authored-by: Andrei Maslennikov <[email protected]>
amaslenn
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
__post_init__
. Member variables were not initialized. Replaced__post_init__
with__init__
.Test Plan