Implement initial Windows CI support for the Python cuda-cccl library. #6160
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 288ee4c |
This comment has been minimized.
This comment has been minimized.
tpn
force-pushed
the
5289-windows-ci-python-cuda-cccl-support-v2
branch
from
288ee4c to
a5b63f5
Compare
|
/ok to test a5b63f5 |
tpn
force-pushed
the
5289-windows-ci-python-cuda-cccl-support-v2
branch
from
a5b63f5 to
6c8a2f2
Compare
This comment has been minimized.
This comment has been minimized.
|
/ok to test 6c8a2f2 |
tpn
changed the title
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Did an initial review of the infra side of things, left a couple notes.
Run a test with an override matrix of
- {jobs: ['test'], project: 'python', ctk: ['12.0', '12.X', '13.0', '13.X'], cxx: ['msvc'], py_version: ['3.10', '3.11', '3.12', '3.13'], gpu: 'l4'}
to make sure that this works on the same matrix as the linux wheels. We'll need to add coverage to the pr/nightly/weekly workflows once that's working.
This comment has been minimized.
This comment has been minimized.
tpn
force-pushed
the
5289-windows-ci-python-cuda-cccl-support-v2
branch
from
7ed6cc5 to
f18f99e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alliepiper
force-pushed
the
5289-windows-ci-python-cuda-cccl-support-v2
branch
from
fde3df2 to
43202da
Compare
This comment has been minimized.
This comment has been minimized.
| param( | ||
| [Parameter(Mandatory, Position = 0)] | ||
| [ValidatePattern('^\d+\.\d+$')] | ||
| [string]$Version |
There was a problem hiding this comment.
It's not important, nor does it matter greatly, but there is a canonical version type. https://learn.microsoft.com/en-us/dotnet/api/system.version?view=net-9.0
There was a problem hiding this comment.
TIL! I'll revisit during next set of changes.
tpn
force-pushed
the
5289-windows-ci-python-cuda-cccl-support-v2
branch
from
43202da to
b939555
Compare
|
/ok to test c8f0d53 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Allison Piper <[email protected]>
tpn
force-pushed
the
5289-windows-ci-python-cuda-cccl-support-v2
branch
from
c8f0d53 to
4cdb8e8
Compare
|
/ok to test 4cdb8e8 |
|
/ok to test ff2c504 |
🥳 CI Workflow Results🟩 Finished in 5h 30m: Pass: 100%/261 | Total: 1d 16h | Max: 58m 47s | Hits: 99%/377909See results here. |
6 participants
This looks ready for a more thorough review now, all tests are passing. This PR supersedes the WIP PR that was created pre compute/coop rename. I figured it was easier to create a new branch and squash all those commits to make the rebase from main easier.