-
Notifications
You must be signed in to change notification settings - Fork 284
[backport -> 3.1.x][libcu++] Rename memory resource concepts to indicate asynchronous allocations are the default ones (#5313) #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+790
−763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locations are the default ones (NVIDIA#5313) * Rename resource to synchronous_resource * Add `sync` suffix to synchronous allocate and deallocate * Rename memory resource concepts and member functions * Leave everything under experimental define for now * Fix docs * Fix format * Some docs fixes * Fix format --------- Co-authored-by: Michael Schellenberger Costa <[email protected]> (cherry picked from commit dd218ad)
bernhardmgruber
approved these changes
Aug 11, 2025
elstehle
approved these changes
Aug 11, 2025
🟨 CI finished in 4h 03m: Pass: 99%/205 | Total: 4d 09h | Avg: 30m 48s | Max: 2h 34m | Hits: 79%/338337
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| +/- | libcu++ |
| +/- | CUB |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 205)
| # | Runner |
|---|---|
| 128 | linux-amd64-cpu16 |
| 23 | windows-amd64-cpu16 |
| 14 | linux-amd64-gpu-h100-latest-1 |
| 14 | linux-amd64-gpu-rtxa6000-latest-1 |
| 12 | linux-arm64-cpu16 |
| 11 | linux-amd64-gpu-rtx2080-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
🟩 CI finished in 5h 31m: Pass: 100%/205 | Total: 4d 09h | Avg: 30m 47s | Max: 2h 34m | Hits: 79%/339596
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| +/- | libcu++ |
| +/- | CUB |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 205)
| # | Runner |
|---|---|
| 128 | linux-amd64-cpu16 |
| 23 | windows-amd64-cpu16 |
| 14 | linux-amd64-gpu-h100-latest-1 |
| 14 | linux-amd64-gpu-rtxa6000-latest-1 |
| 12 | linux-arm64-cpu16 |
| 11 | linux-amd64-gpu-rtx2080-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back port of https://github.com/NVIDIA/cccl/pull/5313 to 3.1 branch
Original change description:
We want to position stream ordered allocations as the default ones. This means that resource concept names and member functions should not have async in the name, instead we will add sync or synchronous to things that are not async capable. We considered requiring stream ordered operation, but ultimately it seemed too limiting for potential future resources.
This PR makes the following renames:
mr::resource -> mr::synchronous_resource
mr::resource_with -> mr::synchronous_resource_with
mr::async_resource -> mr::resource
mr::async_resource_with -> mr::resource_with
.allocate() -> .allocate_sync()
.deallocate() -> .deallocate_sync()
.allocate_async() -> .allocate()
.deallocate_async() -> .deallocate()
Most CCCL Runtime APIs that take a stream as an argument do so in the first position. This way it's easier to tell something is asynchronous without the async in the name. This change aligns memory resources with this rule, now allocate and deallocate takes stream_ref as first argument instead of the last one.