Allow finetuning ESM2 with [un]frozen encoder #620
Merged
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
farhadrgh
requested review from
jstjohn,
malcolmgreaves,
skothenhill-nv,
dorotat-nv,
pstjohn and
jwilber
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 116 116
Lines 6966 6967 +1
=======================================
+ Hits 6035 6036 +1
Misses 931 931 ☔ View full report in Codecov by Sentry. |
pstjohn
approved these changes
Jan 21, 2025
jstjohn
approved these changes
Jan 21, 2025
Signed-off-by: Farhad Ramezanghorbani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
overlap_grad_reduce=Truecauses communication issue in gradient synchronization step when the encoder parameters are not frozen.This PR changes the default for
overlap_grad_reduceand exposesconfig.encoder_frozento optionally [un]freeze the encoder parameters.Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Usage
Pre-submit Checklist