Skip to content

Commit 8d8f56b

Browse files
authored
run trufflehog on entire main branch on push action (#605)
### Description Trufflehog is currently failing on the main branch when we only run on diffs, since it ends up comparing the head of main against itself. This should allow us to check the entire main branch for secrets when it runs post-merge. ### Type of changes <!-- Mark the relevant option with an [x] --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by applying the relevant labels: - [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. ### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [ ] I have tested these changes locally - [ ] I have updated the documentation accordingly - [ ] I have added/updated tests as needed - [ ] All existing tests pass successfully --------- Signed-off-by: Peter St. John <[email protected]>
1 parent 8cc749d commit 8d8f56b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/unit-tests.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
- uses: trufflesecurity/trufflehog@main
3434
with:
3535
path: ./
36-
base: ${{ github.event.repository.default_branch }}
36+
base: ${{ github.event_name != 'push' && github.event.repository.default_branch || '' }}
3737
head: HEAD
3838
extra_args: --only-verified
3939

@@ -69,6 +69,7 @@ jobs:
6969
with:
7070
image: nemoci.azurecr.io/bionemo/build-cache
7171
pull-request-cache: true
72+
extra-cache-from: ${{ github.event_name == 'merge_group' && 'nemoci.azurecr.io/bionemo/build-cache:main' || '' }}
7273

7374
- name: Build and push
7475
uses: docker/build-push-action@v5

0 commit comments

Comments
 (0)