Skip to content

Conversation

@crazydemo
Copy link
Collaborator

@crazydemo crazydemo commented Oct 23, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Improved GPU memory management by enhancing cache eviction efficiency.
  • Tests

    • Updated multi-GPU test configurations and expectations.
    • Added waivers for slow I/O tests to improve test suite reliability.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@crazydemo crazydemo requested a review from a team as a code owner October 23, 2025 08:12
@crazydemo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22276 [ run ] triggered by Bot. Commit: e2ca8dc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22276 [ run ] completed with state SUCCESS. Commit: e2ca8dc
/LLM/release-1.1/L0_MergeRequest_PR pipeline #239 completed with status: 'SUCCESS'

@crazydemo
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

📝 Walkthrough

Walkthrough

Configuration updates to GPU allocation for Llama3.1-70B-BF16 tests, changing from 2-GPU to 8-GPU setup. Memory management enhancement in fixture via gc.collect(). Test waiver entries adjusted and expanded for slow I/O scenarios.

Changes

Cohort / File(s) Summary
Memory management enhancement
tests/integration/defs/conftest.py
Added gc.collect() invocation before torch.cuda.empty_cache() in torch_empty_cache fixture when CUDA is available, improving memory pressure relief.
GPU allocation and memory metric updates
tests/integration/defs/test_e2e.py
Updated Llama3.1-70B-BF16 multi-GPU test expectations: GPU count increased from 2 to 8; memory usage updated from 91.0 to 24.6.
Test parameterization updates
tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/qa/llm_function_core_sanity.txt, tests/integration/test_lists/qa/llm_function_nim.txt
Updated test references for multi-GPU Llama3.1-70B-BF16 quickstart from suffix -2 to -8 across all three test list files.
Test waiver management
tests/integration/test_lists/qa/waives.txt
Removed one existing SKIP waiver for test_ptp_scaffolding. Added six new SKIP waivers (marked as slow I/O) for Nemotron Ultra auto_dtype, Kimi K2 fp8_blockscale, and DeepSeek-V3 multi-GPU tests, with both plain and full-qualified prefixes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are predominantly parameter value updates and configuration adjustments with minimal logic modifications. The gpu count and memory metric changes require verification that they align with hardware capabilities. The waiver additions are routine test management entries. The gc.collect() addition is a straightforward memory optimization with no complex interaction logic.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is substantially incomplete and consists almost entirely of the repository's template boilerplate with no actual content provided. The two critical sections—Description (explaining the issue and solution) and Test Coverage (listing relevant safeguarding tests)—are completely empty. The author has only checked a box in the PR Checklist without providing substantive information about what changes were made, why they were necessary, or how they are tested. This falls clearly into the "largely incomplete" category and does not meet the minimum requirements for a properly documented PR. The author should complete the Description section by explaining the purpose of the cache-cleaning change and why it addresses the hang cases. The Test Coverage section should list the specific tests (e.g., test_e2e.py, conftest.py tests) that validate these changes. This information is essential for code review and understanding the intent of the modifications.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][test] Clean cache for certain easily hang cases" refers to a real and specific part of the changeset: the addition of gc.collect() in the torch_empty_cache fixture within conftest.py to improve memory pressure relief before cache eviction. This is clearly communicated and not misleading. While the title doesn't capture all changes in the PR (such as the test parameter updates from 2 to 8 GPUs and memory mapping adjustments across multiple test files), it does convey the primary infrastructure improvement intent for addressing hang cases. The title meets the criteria of being clear, specific, and referring to a legitimate aspect of the change without being off-topic or vague.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2c976c and a46b18e.

📒 Files selected for processing (6)
  • tests/integration/defs/conftest.py (2 hunks)
  • tests/integration/defs/test_e2e.py (2 hunks)
  • tests/integration/test_lists/qa/llm_function_core.txt (1 hunks)
  • tests/integration/test_lists/qa/llm_function_core_sanity.txt (1 hunks)
  • tests/integration/test_lists/qa/llm_function_nim.txt (1 hunks)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/integration/defs/conftest.py
  • tests/integration/defs/test_e2e.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/integration/defs/conftest.py
  • tests/integration/defs/test_e2e.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/integration/defs/conftest.py
  • tests/integration/defs/test_e2e.py
🧠 Learnings (2)
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/qa/llm_function_core_sanity.txt
  • tests/integration/test_lists/qa/llm_function_core.txt
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/test_lists/qa/llm_function_core.txt (1)

637-637: GPU allocation update for multi-GPU test consistent across test lists.

Line 637 updates the Llama3.1-70B-BF16 multi-GPU test from 2-GPU to 8-GPU allocation. This change aligns with the broader PR objective to improve cache management for large models and is consistently reflected in related test configuration files (e.g., llm_function_nim.txt).

tests/integration/test_lists/qa/llm_function_nim.txt (1)

421-421: GPU allocation update consistent with other test lists.

Line 421 updates the same Llama3.1-70B-BF16 test to 8-GPU allocation, mirroring the change in llm_function_core.txt. This ensures consistent test expectations across different testing contexts (QA vs. NIM test suites).

tests/integration/test_lists/waives.txt (1)

349-351: New test waivers for slow I/O scenarios on H20-3e configuration.

Lines 349–351 add three SKIP waivers specifically for H20-3e hardware, all citing "slow I/O" as the reason. These waivers target large-model tests (Nemotron Ultra, DeepSeek-V3-671B) that are likely affected by the cache-cleaning improvements described in the PR. The H20-3e scope ensures these waivers do not impact other hardware configurations. This approach is consistent with existing waiver patterns in the file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22371 [ run ] triggered by Bot. Commit: a46b18e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22371 [ run ] completed with state SUCCESS. Commit: a46b18e
/LLM/release-1.1/L0_MergeRequest_PR pipeline #250 (Partly Tested) completed with status: 'SUCCESS'

@crazydemo
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22419 [ reuse-pipeline ] triggered by Bot. Commit: a46b18e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22419 [ reuse-pipeline ] completed with state SUCCESS. Commit: a46b18e
Reusing PR_Github #22371 (Partly Tested) for commit a46b18e

@LarryXFly LarryXFly enabled auto-merge (squash) October 24, 2025 10:05
@xinhe-nv
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22439 [ reuse-pipeline ] triggered by Bot. Commit: 2e36e1b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22439 [ reuse-pipeline ] completed with state SUCCESS. Commit: 2e36e1b
Reusing PR_Github #22371 (Partly Tested) for commit 2e36e1b

@LarryXFly LarryXFly merged commit 1859b55 into NVIDIA:release/1.1 Oct 24, 2025
5 checks passed
@xinhe-nv xinhe-nv deleted the clean_cache branch October 24, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants