Skip to content

Conversation

jieli-matrix
Copy link
Collaborator

@jieli-matrix jieli-matrix commented Oct 23, 2025

Summary by CodeRabbit

  • Tests
    • Updated integration test suite configuration by removing deprecated test cases for specific model implementations and multimodal configurations to streamline testing infrastructure.

Description

Remove all test_llm_multimodal_general cases using TRT backend
Remove test_llm_qwenvl_single_gpu_summary[qwen-vl-chat] case
Remove test_llm_qwen2audio_single_gpu[qwen2_audio_7b_instruct]
Such modifications can fix bug 5587456.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@jieli-matrix jieli-matrix requested a review from a team as a code owner October 23, 2025 06:10
@jieli-matrix
Copy link
Collaborator Author

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

This pull request removes integration test cases from a test configuration file. Deleted test entries include multimodal general tests, Qwen-related variants, Qwenvl tests, and GPT Starcoder configurations. No new tests or test infrastructure were added.

Changes

Cohort / File(s) Summary
Test List Deletions
tests/integration/test_lists/qa/llm_function_nim.txt
Removed multiple test case entries: multimodal general test variants (Phi/Llama/Vision configurations), Multimodal Executor Cpp E2E fp8 test, Qwenvl tests (single GPU summary, audio variants), Qwen-related entries (Qwen2 audio, multi-GPU variants), and GPT Starcoder configurations (1-node 4GPU and weight-only variants).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is partially filled but has significant gaps against the required template. The Description section provides a brief explanation of what is being removed and references bug 5587456, but lacks sufficient detail about the rationale and impact of these changes. The Test Coverage section is completely empty with no relevant tests listed, which is a critical required section. The PR Checklist items (beyond the final checkbox) are not properly addressed, leaving uncertainty about whether the author verified adherence to coding guidelines, appropriate reviewer assignments, and other quality criteria. While the changes themselves are straightforward deletions, the documentation does not adequately demonstrate the necessary pre-merge review. The author should complete the Test Coverage section by explicitly listing which tests validate the removal of these test cases (e.g., CI pipeline results, existing test suites that still pass after removal). The Description should be expanded to explain why these specific test cases cause bug 5587456 and what the intended fix achieves. Additionally, the PR Checklist items should be properly reviewed and indicated to confirm the PR follows coding guidelines and has appropriate reviewer assignments.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The pull request title "[https://nvbugs/5587456][fix] Remove multimodal test cases using TRT backend" accurately and directly describes the main change in the changeset. The raw summary confirms that the primary modification is the removal of test cases from the llm_function_nim.txt file, specifically test_llm_multimodal_general cases and related multimodal test entries. The title is clear, specific, and concise, directly stating both the action taken (remove) and the target (multimodal test cases using TRT backend). A teammate reviewing the commit history would immediately understand that this PR removes specific multimodal test cases as part of a bug fix.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jieli-matrix jieli-matrix self-assigned this Oct 23, 2025
@jieli-matrix jieli-matrix changed the title [nvbug/5587456][fix] remove multimodal test cases using TRT backend [https://nvbugs/5587456][fix] remove multimodal test cases using TRT backend Oct 23, 2025
@jieli-matrix jieli-matrix changed the title [https://nvbugs/5587456][fix] remove multimodal test cases using TRT backend [https://nvbugs/5587456][fix] Remove multimodal test cases using TRT backend Oct 23, 2025
@jieli-matrix jieli-matrix enabled auto-merge (squash) October 23, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants