Skip to content

Conversation

@chenfeiz0326
Copy link
Collaborator

@chenfeiz0326 chenfeiz0326 commented Oct 23, 2025

Summary by CodeRabbit

  • Tests
    • Updated test configuration to remove specific performance test entries from the test suite.

Note: This release contains internal testing infrastructure updates with no end-user visible changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chenfeiz0326 chenfeiz0326 changed the title [TRTLLM-8260][feat] Update perf-sanity test db yml file [TRTLLM-8260][feat] Update perf sanity test db yml file Oct 23, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

Test configuration cleanup: Removed cross-referenced test entries from performance test YAML files. Specifically removed a b300 test reference from the b200 configuration file and b200 test references from the b300 configuration file.

Changes

Cohort / File(s) Summary
Performance Test Configuration Cleanup
tests/integration/test_lists/test-db/perf_sanity_l0_dgx_b200.yml, tests/integration/test_lists/test-db/perf_sanity_l0_dgx_b300.yml
Removed misaligned test entries: deleted b300-referenced test from b200 config and b200-referenced tests from b300 config. Kept matching device-specific test entries intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description contains the repository's template structure but lacks substantive content in critical sections. The "Description" section is completely empty except for an HTML comment placeholder, providing no explanation of what issue is being addressed or what the solution entails. Similarly, the "Test Coverage" section is entirely empty with only a placeholder comment. While the PR checklist checkbox has been marked, the core sections required to communicate the purpose and scope of the changes—particularly the Description section explaining why the perf-sanity test database YAML files are being modified—are missing entirely. This represents a largely incomplete submission that does not meet the template requirements. The author should fill in the "Description" section with a clear explanation of why the perf-sanity test entries are being removed from the YAML files and what problem this resolves. Additionally, the "Test Coverage" section must be completed to document which tests validate these configuration changes. The PR title provided in the objectives ([TRTLLM-8260][feat]) is appropriately formatted but should be confirmed in the actual PR body. These sections are essential for code reviewers to understand the rationale and impact of the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The pull request title "[None][infra] Minor Update on Perf Sanity Testdb Files" is directly related to the changeset, which involves removing specific test entries from perf sanity test database YAML files. The title accurately identifies the affected files and nature of the changes as infrastructure updates. While the term "Minor Update" is somewhat generic and doesn't specify the exact nature of the changes (removal of test entries), it remains descriptive enough to convey that there are infrastructure modifications to perf sanity test database files, allowing a teammate scanning the history to understand the general intent of the change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chenfeiz0326 chenfeiz0326 changed the title [TRTLLM-8260][feat] Update perf sanity test db yml file [TRTLLM-8260][feat] Update Perf Sanity TestDB File Oct 23, 2025
@chenfeiz0326 chenfeiz0326 changed the title [TRTLLM-8260][feat] Update Perf Sanity TestDB File [None][chore] Minor Update on Perf Sanity Testdb Files Oct 23, 2025
@chenfeiz0326 chenfeiz0326 changed the title [None][chore] Minor Update on Perf Sanity Testdb Files [None][infra] Minor Update on Perf Sanity Testdb Files Oct 23, 2025
@chenfeiz0326 chenfeiz0326 requested a review from chzblych October 23, 2025 06:27
@chenfeiz0326
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22259 [ run ] triggered by Bot. Commit: 3ab2067

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22260 [ run ] triggered by Bot. Commit: 3ab2067

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22259 [ run ] completed with state ABORTED. Commit: 3ab2067

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22260 [ run ] completed with state SUCCESS. Commit: 3ab2067
/LLM/main/L0_MergeRequest_PR pipeline #16782 completed with status: 'FAILURE'

@chenfeiz0326
Copy link
Collaborator Author

/bot run

1 similar comment
@chenfeiz0326
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22487 [ run ] triggered by Bot. Commit: 3ab2067

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22487 [ run ] completed with state SUCCESS. Commit: 3ab2067
/LLM/main/L0_MergeRequest_PR pipeline #16945 completed with status: 'FAILURE'

@chenfeiz0326
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22588 [ run ] triggered by Bot. Commit: 3ab2067

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22588 [ run ] completed with state FAILURE. Commit: 3ab2067
/LLM/main/L0_MergeRequest_PR pipeline #17028 completed with status: 'FAILURE'

Signed-off-by: Chenfei Zhang <[email protected]>
@chenfeiz0326 chenfeiz0326 force-pushed the chenfeiz/fix-perf-sanity-test-db-yaml branch from 3ab2067 to 6766ee7 Compare October 27, 2025 08:29
@chenfeiz0326
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22615 [ run ] triggered by Bot. Commit: 6766ee7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22615 [ run ] completed with state SUCCESS. Commit: 6766ee7
/LLM/main/L0_MergeRequest_PR pipeline #17048 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants