Skip to content

Conversation

@yunruis
Copy link
Contributor

@yunruis yunruis commented Oct 22, 2025

Summary by CodeRabbit

  • Documentation
    • Updated baseline performance metrics reflecting revised efficiency loss measurements in technical blog article
    • Added production configuration guidance with detailed YAML configuration examples for easy implementation
    • Enhanced experimental design documentation section covering evaluation of multiple configuration parameters and their impact on system throughput and latency
    • Reorganized content structure for improved readability

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yunruis yunruis requested a review from a team as a code owner October 22, 2025 06:25
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

📝 Walkthrough

Walkthrough

A technical blog document about ADP Balance Strategy was updated with revised baseline performance metrics showing increased efficiency loss, reorganized production configuration guidance with duplicated YAML snippets, and added experimental design details for Pareto analysis evaluation.

Changes

Cohort / File(s) Summary
Blog Documentation Update
docs/source/blogs/tech_blog/blog10_ADP_Balance_Strategy.md
Updated baseline performance values (SOL TPS 39,552 vs actual 25,664 with 54% efficiency loss); reorganized and duplicated Production Configuration blocks containing YAML attention_dp_config snippets; added Experimental Design subsection under Pareto Analysis describing timeout_iters and batching_wait_iters configuration evaluation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is largely incomplete and appears to contain only the template structure with no substantive content filled in. The author has not provided an actual PR title in the required format, a description explaining the changes and their rationale, or test coverage information. The PR Checklist items remain mostly unchecked beyond the final generic acknowledgment box. While the raw_summary indicates the PR updates documentation (specifically blog10_ADP_Balance_Strategy.md with baseline performance changes and configuration adjustments), this context is not reflected in the PR description itself. The author needs to provide a concrete PR title in the format [ticket/issue/None][type] Summary, fill in the Description section with an explanation of what changes were made and why, and provide relevant test coverage information. Additionally, the PR Checklist items should be reviewed and appropriately marked to confirm adherence to coding guidelines, test requirements, documentation updates, and other applicable criteria for this documentation-focused change.
Title Check ❓ Inconclusive The PR title "[None][doc] Paragraph adjustment and fix statistic" is related to the actual changes in the pull request—which include fixing performance gap statistics and reorganizing documentation sections—but the language is quite vague and generic. Terms like "paragraph adjustment" and "fix statistic" lack specificity and do not clearly convey what the primary changes are. The title fails to communicate the substantive reorganization of production configuration blocks, the addition of an Experimental Design subsection, or the specific nature of the statistical fix (the efficiency loss metric changing from 35% to 54%). A reviewer scanning the pull request history would struggle to understand the actual scope and importance of the changes from this title alone. To improve clarity, the title should be more specific about the key changes, such as specifying which statistics were corrected (e.g., "Update ADP Balance Strategy blog baseline performance metrics") or highlighting the document reorganization if that is the primary intent. Avoid generic terms like "paragraph adjustment" and instead use concrete descriptions of what was changed. This would help teammates quickly understand the purpose of the changes when reviewing commit history.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07edac2 and f9ae562.

📒 Files selected for processing (1)
  • docs/source/blogs/tech_blog/blog10_ADP_Balance_Strategy.md (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (2)
docs/source/blogs/tech_blog/blog10_ADP_Balance_Strategy.md (2)

319-344: Pareto Analysis section looks good.

The expanded "Experimental Design" description at line 323 clearly explains that the analysis evaluates multiple timeout_iters and batching_wait_iters configurations under varying system loads, which directly supports the Pareto frontier visualization in Figure 7. The section is well-structured and provides appropriate context for understanding the throughput-latency trade-offs.


309-317: The production configuration block is not duplicated—no action needed.

Search results confirm only one occurrence each of "Production Configuration" (line 309), "attention_dp_config" (line 313), and "enable_balance" (line 314) in the entire 367-line document. The configuration block at lines 309–317 is unique and appropriately positioned. The AI summary's claim of duplication does not match the actual file content.

Likely an incorrect or invalid review comment.

@yunruis yunruis changed the title [None][Chore] Paragraph adjustment and fix statistic [None][doc] Paragraph adjustment and fix statistic Oct 22, 2025
@yunruis yunruis force-pushed the user/yunruis/fix_doc_blog10 branch from f9ae562 to d3f4081 Compare October 22, 2025 06:47
@nv-guomingz nv-guomingz enabled auto-merge (squash) October 22, 2025 06:52
@nv-guomingz
Copy link
Collaborator

/bot skip --comment "doc change only"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22144 [ skip ] triggered by Bot. Commit: d3f4081

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22144 [ skip ] completed with state SUCCESS. Commit: d3f4081
Skipping testing for commit d3f4081

@nv-guomingz nv-guomingz merged commit 8c9fda4 into NVIDIA:main Oct 22, 2025
5 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants