[None][fix] fixed cached model path in test

[MrGeva]

Summary by CodeRabbit

• Tests
  • Fixed benchmark test configuration to ensure consistent model parameter alignment during test execution.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[MrGeva]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

A test file was modified to change a function argument from using the test parameter model_name to using config["args"]["model"], aligning the model value passed to the benchmark runner with the model configuration used elsewhere in the test.

Changes

Cohort / File(s)	Summary
Test parameter alignment tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py	Updated run_benchmark call to use config["args"]["model"] instead of model_name parameter for consistency with configuration-based model specification

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check	⚠️ Warning	The PR description fails to meet the template requirements. While the PR title correctly follows the specified format [None][fix] fixed cached model path in test, the critical sections are empty: the Description section contains only an HTML comment placeholder with no explanation of the issue or solution, and the Test Coverage section similarly lacks any listed test cases. The PR Checklist shows only one generic item checked while the substantive guidance items (PR description clarity, coding guidelines compliance, test case provision) remain unchecked. According to the raw summary, the change involves modifying a test to use config["args"]["model"] instead of a model_name parameter, but this rationale is absent from the PR body, leaving reviewers without essential context about the purpose and testing of the changes.	The author must complete the PR description by filling in the Description section with an explanation of why the model parameter reference was changed in the test, and populate the Test Coverage section with details about which tests validate this change. Additionally, the PR Checklist items should be reviewed and appropriately checked to confirm compliance with the repository's coding guidelines, test requirements, and documentation standards. At minimum, items confirming the description clarity, coding guidelines compliance, and test case provision should be explicitly addressed.
Title Check	❓ Inconclusive	The PR title "[None][fix] fixed cached model path in test" follows the correct format specified in the template with the ticket identifier [None] and type [fix]. The title does relate to the changeset in that it references a fix within a test file. However, the specific terminology "cached model path" does not clearly or precisely match the actual change described in the raw summary, which indicates the modification was about switching the model parameter passed to run_benchmark from test parameter model_name to config["args"]["model"]. The imprecise terminology creates ambiguity about what exactly was fixed, making it unclear whether the title accurately describes the nature of the change.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8dc4aac and c3c2622.

📒 Files selected for processing (1)

• tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

• tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

• tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

• tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py

🧬 Code graph analysis (1)

tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py (1)

tests/unittest/llmapi/apps/_test_trtllm_serve_benchmark.py (1)

• dataset_path (39-44)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

[tensorrt-cicd]

PR_Github #22086 [ run ] triggered by Bot. Commit: c3c2622

[tensorrt-cicd]

PR_Github #22086 [ run ] completed with state SUCCESS. Commit: c3c2622
/LLM/main/L0_MergeRequest_PR pipeline #16653 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #22138 [ run ] triggered by Bot. Commit: 0990a53

[tensorrt-cicd]

PR_Github #22138 [ run ] completed with state SUCCESS. Commit: 0990a53
/LLM/main/L0_MergeRequest_PR pipeline #16694 completed with status: 'FAILURE'

[MrGeva]

/bot run

[tensorrt-cicd]

PR_Github #22164 [ run ] triggered by Bot. Commit: 0990a53

[tensorrt-cicd]

PR_Github #22164 [ run ] completed with state SUCCESS. Commit: 0990a53
/LLM/main/L0_MergeRequest_PR pipeline #16712 completed with status: 'SUCCESS'