Skip to content

Conversation

@zheyuf
Copy link
Collaborator

@zheyuf zheyuf commented Oct 21, 2025

Summary by CodeRabbit

  • Tests
    • Enabled previously skipped test cases for weight-only quantization with specific parameter combinations, improving test coverage and ensuring code reliability for these scenarios.

Description

Unable to reproduce this bug. Details are documented in NVBugs: https://nvbugs/5576192. We will unwaive the test to see if it can pass the CI.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Zheyu Fu <[email protected]>
@zheyuf
Copy link
Collaborator Author

zheyuf commented Oct 21, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22081 [ run ] triggered by Bot. Commit: 0b379a9

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22081 [ run ] completed with state SUCCESS. Commit: 0b379a9
/LLM/release-1.1/L0_MergeRequest_PR pipeline #219 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@zheyuf zheyuf marked this pull request as ready for review October 21, 2025 22:13
@zheyuf zheyuf requested a review from a team as a code owner October 21, 2025 22:13
@zheyuf zheyuf requested a review from schetlur-nv October 21, 2025 22:13
@zheyuf zheyuf enabled auto-merge (squash) October 21, 2025 22:13
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

📝 Walkthrough

Walkthrough

A runtime skip condition in the weight-only quantization GEMM test was removed, enabling the test to execute for the previously-skipped parameter combination (k=512, n=32768) instead of bypassing it.

Changes

Cohort / File(s) Summary
Test skip removal
tests/unittest/_torch/thop/parallel/test_weight_only_quant_gemm.py
Removed conditional skip for k=512 and n=32768 test case, allowing the test to run for this parameter combination

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The PR description is incomplete regarding required template sections. While the description section provides a brief explanation of the intent (unwaiving a test due to inability to reproduce a bug, with reference to NVBugs), the Test Coverage section—which is explicitly required by the template to "list clearly what are the relevant test(s) that can safeguard the changes"—is entirely empty and contains only the placeholder comment. Additionally, the Description section is quite vague and minimal in explaining the context and rationale beyond the basic action taken. The title appears properly formatted per the template requirements. The author should fill out the Test Coverage section by clearly documenting which test or tests are being unwaived and how they validate the changes. The description should also be expanded to provide more context about the specific test case (k == 512 and n == 32768), the original issue, and why unwaiving is appropriate at this time. These additions will ensure the PR description fully complies with the repository's template requirements.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title follows the correct format with a valid NVBugs ID reference, a recognized type [fix], and a clear summary. The title "Unwaive the test for test_weight_only_quant_gemm" directly and specifically describes the main change in the pull request, which according to the raw summary is the removal of a runtime skip in test_weight_only_quant_gemm for specific parameter combinations. The title accurately captures the primary change and would be clear to someone scanning the PR history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zheyuf zheyuf merged commit d2c976c into NVIDIA:release/1.1 Oct 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants