Skip to content

Conversation

@farazkh80
Copy link
Collaborator

@farazkh80 farazkh80 commented Oct 21, 2025

Summary by CodeRabbit

Release Notes

  • New Features

    • Added attention sink support in Flash Attention kernels with SM version flexibility
    • Introduced FP8/FP4 mixed precision configuration support for enhanced model quantization
    • Added bias support in cuBLAS matrix multiplication operations
    • Added custom cuBLAS matrix multiply path option for optimized computation
  • Improvements

    • Extended FP4 support across broader range of SM versions
    • Relaxed GPU capability constraints for improved compatibility
    • Optimized kernel binaries for better performance
  • Tests

    • Added test coverage for GPT-OSS-20B and GPT-OSS-120B models
    • Improved test skip conditions for better hardware compatibility

Description

Cherry-pick gpt-oss for sm120/121 PR commit from main to release/1.1.

NVBug https://nvbugspro.nvidia.com/bug/5569719

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@farazkh80 farazkh80 requested a review from a team as a code owner October 21, 2025 17:12
@farazkh80 farazkh80 changed the title [https://nvbugspro.nvidia.com/bug/5569719][fix]Gptoss sm120 cherrypick to release 1.1 [https://nvbugspro.nvidia.com/bug/5569719][fix] Gptoss sm120 cherrypick to release 1.1 Oct 21, 2025
@farazkh80 farazkh80 changed the title [https://nvbugspro.nvidia.com/bug/5569719][fix] Gptoss sm120 cherrypick to release 1.1 [nvbug-5569719][fix] Gptoss sm120 cherrypick to release 1.1 Oct 21, 2025
@farazkh80 farazkh80 changed the title [nvbug-5569719][fix] Gptoss sm120 cherrypick to release 1.1 [https://nvbugspro.nvidia.com/bug/5569719][fix] Gptoss sm120 cherrypick to release 1.1 Oct 21, 2025
@farazkh80 farazkh80 changed the title [https://nvbugspro.nvidia.com/bug/5569719][fix] Gptoss sm120 cherrypick to release 1.1 [https://nvbugs/5569719][fix] Gptoss sm120 cherrypick to release 1.1 Oct 21, 2025
@coderabbitai

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

Copy link
Collaborator

@schetlur-nv schetlur-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until nvbug conversation with Product resolves. This is a feature addition (even though it came in as a bug). Would like to bottom out.

@farazkh80 farazkh80 force-pushed the gptoss-sm120-cherrypick-to-release-1.1 branch 2 times, most recently from edfedc0 to 6bc862a Compare October 24, 2025 00:51
Signed-off-by: Perkz Zheng <[email protected]>
Signed-off-by: list <[email protected]>
Signed-off-by: Vincent Huang <[email protected]>
Co-authored-by: Perkz Zheng <[email protected]>
Co-authored-by: Vincent Huang <[email protected]>
Signed-off-by: list <[email protected]>
@farazkh80 farazkh80 force-pushed the gptoss-sm120-cherrypick-to-release-1.1 branch from 6bc862a to 20f5bdc Compare October 24, 2025 00:58
@farazkh80
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22336 [ run ] triggered by Bot. Commit: 20f5bdc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22336 [ run ] completed with state SUCCESS. Commit: 20f5bdc
/LLM/release-1.1/L0_MergeRequest_PR pipeline #247 completed with status: 'FAILURE'

@farazkh80
Copy link
Collaborator Author

/bot run

@NVIDIA NVIDIA deleted a comment from tensorrt-cicd Oct 24, 2025
@NVIDIA NVIDIA deleted a comment from tensorrt-cicd Oct 24, 2025
@NVIDIA NVIDIA deleted a comment from tensorrt-cicd Oct 24, 2025
@farazkh80 farazkh80 requested a review from schetlur-nv October 24, 2025 15:51
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22451 [ run ] triggered by Bot. Commit: 20f5bdc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22451 [ run ] completed with state SUCCESS. Commit: 20f5bdc
/LLM/release-1.1/L0_MergeRequest_PR pipeline #258 completed with status: 'FAILURE'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants