Skip to content

Coalesce text diffs in streaming requests. #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/apps/fastapi_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ async def generate(self, request: Request) -> Response:
sampling_params=sampling_params)

async def stream_results() -> AsyncGenerator[bytes, None]:
last_text_len: int = 0
async for output in promise:
yield output.outputs[0].text_diff.encode("utf-8")
text_diff, last_text_len = output.outputs[0].text_diff_safe(last_text_len)
yield text_diff.encode("utf-8")

if streaming:
return StreamingResponse(stream_results())
Expand Down
3 changes: 3 additions & 0 deletions tensorrt_llm/executor/postproc_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
@dataclass(kw_only=True)
class PostprocArgs:
first_iteration: bool = True
last_text_len: int = 0
last_logprobs_len: int = 0
last_token_ids_len: int = 0
num_prompt_tokens: Optional[int] = None
tokenizer: Optional[TransformersTokenizer] = None

Expand Down
30 changes: 21 additions & 9 deletions tensorrt_llm/executor/result.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from dataclasses import dataclass, field
from queue import Empty, Queue
from typing import (TYPE_CHECKING, Any, Callable, List, Literal, NamedTuple,
Optional, TypeAlias, Union)
Optional, TypeAlias, Union, Tuple)
from weakref import WeakMethod

import torch
Expand Down Expand Up @@ -89,8 +89,11 @@ class CompletionOutput:
Attributes:
length (int): The number of generated tokens.
token_ids_diff (List[int]): Newly generated token ids.
logprobs_diff (List[float]): Logprobs of newly generated tokens.
text_diff (str): Newly generated tokens.

Accessors:
token_ids_diff_safe(int) -> Tuple[List[int], int]: Newly generated token ids since the given length.
logprobs_diff_safe(int) -> Tuple[List[float], int]: Logprobs of newly generated tokens since the given length.
text_diff_safe(int) -> Tuple[str, int]: Newly generated tokens since the given length.
"""
index: int
text: str = ""
Expand Down Expand Up @@ -119,17 +122,26 @@ class CompletionOutput:
def length(self) -> int:
return len(self.token_ids)

@property
def text_diff(self) -> str:
return self.text[self._last_text_len:]
def text_diff_safe(self, last_text_len) -> Tuple[str, int]:
return self.text[last_text_len:], len(self.text)

def logprobs_diff_safe(self, last_logprobs_len) -> Tuple[List[float], int]:
return self.logprobs[last_logprobs_len:], len(self.logprobs)

def token_ids_diff_safe(self, last_token_ids_len) -> Tuple[List[int], int]:
return self.logprobs[last_token_ids_len:], len(self.logprobs)

#@property
#def text_diff(self) -> str:
# return self.text[self._last_text_len:]

@property
def token_ids_diff(self) -> List[int]:
return self.token_ids[self._last_token_ids_len:]

@property
def logprobs_diff(self) -> List[float]:
return self.logprobs[self._last_logprobs_len:]
#@property
#def logprobs_diff(self) -> List[float]:
# return self.logprobs[self._last_logprobs_len:]


class GenerationResultBase:
Expand Down
12 changes: 8 additions & 4 deletions tensorrt_llm/serve/postprocess_handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ def yield_first_chat(num_tokens: int,
if finish_reason_sent[i]:
continue

delta_text = output.text_diff
delta_text, args.last_text_len = output.text_diff_safe(args.last_text_len)
if delta_text == '' and not output.finish_reason and not output.stop_reason:
continue

in_reasoning, delta_text, reasoning_delta_text = apply_reasoning_parser(
args, i, delta_text, True)
Expand All @@ -162,8 +164,8 @@ def yield_first_chat(num_tokens: int,
delta=delta_message,
finish_reason=None)
if args.return_logprobs:
logprobs = output.logprobs_diff
token_ids = output.token_ids_diff
logprobs, args.last_logprobs_len = output.logprobs_diff_safe(args.last_logprobs_len)
token_ids, args.last_token_ids_len = output.token_ids_diff_safe(args.last_token_ids_len)
choice.logprobs = create_logprobs(token_ids, args.tokenizer, logprobs)
if output.finish_reason is not None:
choice.finish_reason = output.finish_reason
Expand Down Expand Up @@ -282,9 +284,11 @@ def completion_stream_post_processor(rsp: DetokenizedGenerationResultBase, args:
include_continuous_usage = False

for output in rsp.outputs:
delta_text = output.text_diff
delta_text, args.last_text_len = output.text_diff_safe(args.last_text_len)
if args.echo and args.first_iteration:
delta_text = args.prompt + delta_text
if delta_text == '' and not output.finish_reason and not output.stop_reason:
continue
choice = CompletionResponseStreamChoice(
index=args.prompt_idx * args.num_choices + output.index,
text=delta_text,
Expand Down
2 changes: 1 addition & 1 deletion tests/unittest/llmapi/run_llm_with_postproc.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def yield_first_chat(idx: int, role: str = None, content: str = None):
if finish_reason_sent[i]:
continue

delta_text = output.text_diff
delta_text, args.last_text_len = output.text_diff_safe(args.last_text_len)
delta_message = DeltaMessage(content=delta_text)

choice = ChatCompletionResponseStreamChoice(index=i,
Expand Down