Skip to content

Commit

Permalink
[NFC][mlir-tensorrt] Fix minor issues (#318)
Browse files Browse the repository at this point in the history
This PR makes the following changes,
- Add code owners for `mir-tensorrt` part to help review.
- Add torch as dependency in `requirements-dev.txt`. Torch based test is
used in Python API.
- Fix an error in README.
  • Loading branch information
shelkesagar29 authored Oct 29, 2024
1 parent c643ec3 commit 07402ef
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
.github/workflows/* @parthchadha @pranavm-nvidia @jhalakpatel @yizhuoz004 @shelkesagar29
/mlir-tensorrt/ @christopherbate @shelkesagar29
6 changes: 3 additions & 3 deletions mlir-tensorrt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ cmake --preset ninja-llvm
ninja -C build all

# Build and run tests
ninja -C build/mlir-tensorrt check-mlir-executor
ninja -C build/mlir-tensorrt check-mlir-tensorrt-dialect
ninja -C build/mlir-tensorrt check-mlir-tensorrt
ninja -C build check-mlir-executor
ninja -C build check-mlir-tensorrt-dialect
ninja -C build check-mlir-tensorrt

# Build wheels (output in `build/wheels`)
ninja -C build mlir-tensorrt-all-wheels
Expand Down
2 changes: 2 additions & 0 deletions mlir-tensorrt/python/requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Torch is required by `optimum`. This will let PIP select the CPU version.
# The GPU version installs `nvidia-` pip packages which confuse JAX.
-r requirements.txt
--extra-index-url https://download.pytorch.org/whl/cpu
numpy<2.0.0
click
matplotlib
Expand All @@ -13,3 +14,4 @@ nvidia-ml-py
black
build
psutil
torch==2.1.0+cpu

0 comments on commit 07402ef

Please sign in to comment.