test(e2e): migrate agent turn latency to vitest#5554
Open
cv wants to merge 14 commits into
Open
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new live Vitest e2e test ( ChangesAgent Turn Latency E2E Scenario
Sequence Diagram(s)sequenceDiagram
participant CI as GitHub Actions
participant Test as agent-turn-latency.test.ts
participant OpenClaw as OpenClaw Sandbox
participant Hermes as Hermes Sandbox
participant Artifacts as e2e-artifacts/
CI->>Test: vitest run (with NVIDIA_INFERENCE_API_KEY)
Test->>Test: shouldRunLiveE2EScenarios() gate
Test->>OpenClaw: installSandbox() — install.sh with retries
OpenClaw-->>Test: install success
Test->>OpenClaw: run agent via sandbox shell (record bigint start)
OpenClaw-->>Test: response text
Test->>Test: assert contains 42 and within latency max
Test->>OpenClaw: destroy sandbox
Test->>Hermes: installSandbox() — install.sh with retries
Hermes-->>Test: install success
Test->>Hermes: curl /v1/chat/completions (record bigint start)
Hermes-->>Test: JSON response
Test->>Test: chatContent() extract, assert 42 and latency
Test->>Artifacts: write turn-latency-results.json
CI->>CI: upload artifacts from e2e-artifacts/vitest/agent-turn-latency/
CI->>CI: report-to-pr includes agent-turn-latency-vitest result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
79 tasks
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the branch is 96%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the branch is 46%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
Updated |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e-scenario/live/agent-turn-latency.test.ts`:
- Around line 157-165: The openclawConfig variable captures raw config output
without redacting sensitive credentials, creating a potential API key leakage
risk into artifacts. The Hermes config path already implements redaction of
apiKey values, but openclawConfig does not. Add similar redaction logic to
openclawConfig to remove or mask sensitive fields like apiKey before the output
is captured in the artifact, following the same redaction pattern that is
already applied to the Hermes config to prevent credentials from leaking into
logs and artifacts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e9e10c9c-b55e-4d56-96da-a59a80764c50
📒 Files selected for processing (2)
.github/workflows/e2e-vitest-scenarios.yamltest/e2e-scenario/live/agent-turn-latency.test.ts
Contributor
PR Review AdvisorFindings: 0 needs attention, 13 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
79 tasks
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
…t-turn-latency Signed-off-by: Carlos Villela <cvillela@nvidia.com>
79 tasks
…t-turn-latency Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
…ncy' into e2e-migrate/test-agent-turn-latency Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
…t-turn-latency Signed-off-by: Carlos Villela <cvillela@nvidia.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the real agent turn latency E2E into a typed live Vitest scenario. The new test onboards OpenClaw and Hermes against hosted inference, verifies their managed inference.local configuration, and times one real model-backed turn through each runtime.
Related Issue
Refs #5098
Changes
test/e2e/test-agent-turn-latency-e2e.sh..github/workflows/e2e-vitest-scenarios.yaml.Type of Change
Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Targeted commands run:
npx biome check --write test/e2e-scenario/live/agent-turn-latency.test.tsNEMOCLAW_RUN_E2E_SCENARIOS=1 npx vitest run --project e2e-scenarios-live test/e2e-scenario/live/agent-turn-latency.test.ts -t __compile_only_nomatch__ --silent=false --reporter=default --passWithNoTestsnpx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.tsnpx tsx scripts/check-test-file-size-budget.ts test/e2e-scenario/live/agent-turn-latency.test.tsnpx tsc --noEmit --strict --moduleResolution bundler --module preserve --target ES2022 --types node --allowImportingTsExtensions test/e2e-scenario/live/agent-turn-latency.test.tsgit diff --checkSigned-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Tests
CI/CD