fix(sandbox/recover): Revert "enforce Hermes env-file secret boundary on probe path"#5547
fix(sandbox/recover): Revert "enforce Hermes env-file secret boundary on probe path"#5547sandl99 wants to merge 2 commits into
Conversation
… on prob…" This reverts commit c4bd014.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoves the Hermes secret-boundary enforcement feature end-to-end: deletes exported marker constants and the ChangesHermes Secret-Boundary Enforcement Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the branch is 96%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the branch is 46%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-5547.docs.buildwithfern.com/nemoclaw |
PR Review AdvisorFindings: 2 needs attention, 2 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/actions/sandbox/process-recovery.ts`:
- Line 490: The fail-closed Hermes boundary check was removed from the
live-gateway recovery path, allowing dashboard and forward recovery for
already-running gateways to proceed without re-validating the Hermes environment
file at `/sandbox/.hermes/.env`. This can leave a poisoned Hermes environment in
place without proper validation failure. Restore the deleted running-gateway
validator check or add an equivalent fail-closed boundary gate before any
dashboard or forward recovery operations in the affected code block (around line
506 and throughout the recovery logic in lines 502-568) to ensure the Hermes
environment is properly validated and `SECRET_BOUNDARY_REFUSED` is emitted when
appropriate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 066c32a2-d2ec-4ac6-a269-3daf3c6e9e4b
📒 Files selected for processing (8)
docs/reference/commands-nemohermes.mdxdocs/reference/commands.mdxsrc/lib/actions/sandbox/connect-flow.test.tssrc/lib/actions/sandbox/connect.tssrc/lib/actions/sandbox/process-recovery.tssrc/lib/agent/hermes-recovery-boundary.tssrc/lib/agent/runtime-hermes-secret-boundary-behavioural.test.tstest/process-recovery.test.ts
💤 Files with no reviewable changes (5)
- docs/reference/commands-nemohermes.mdx
- docs/reference/commands.mdx
- src/lib/actions/sandbox/connect-flow.test.ts
- src/lib/agent/runtime-hermes-secret-boundary-behavioural.test.ts
- src/lib/agent/hermes-recovery-boundary.ts
Signed-off-by: San Dang <sdang@nvidia.com>
#5530 break nemohermes connect. Reverts #5530
Signed-off-by: San Dang sdang@nvidia.com
Summary by CodeRabbit
Summary by CodeRabbit
Refactor
Documentation
Tests