Improve alpha to beta bot migration #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schuellc-nvidia is it still a WIP? |
Pouyanpi
reviewed
Jan 14, 2025
Comment on lines
+153
to
+166
| # Flows that were deprecated and have no replacement | ||
| line = line.replace( | ||
| "manage attentive posture", | ||
| "!!!! DEPRECATED FLOW (please remove): manage attentive posture", | ||
| ) | ||
| line = line.replace( | ||
| "track user presence state", | ||
| "!!!! DEPRECATED FLOW (please remove): track user presence state", | ||
| ) | ||
| line = line.replace( | ||
| "user became no longer present", | ||
| "!!!! DEPRECATED FLOW (please remove): user became no longer present", | ||
| ) | ||
|
|
There was a problem hiding this comment.
does it mean these flows are no longer needed and the functionality is not affected? If yes then should we comment the line?
Pouyanpi
reviewed
Jan 14, 2025
There was a problem hiding this comment.
It'd be nice to document the deprecated flow changes by adding a test like
def test_deprecated_flows_replacement(self):
input_lines = [
"manage attentive posture",
"track user presence state",
"user became no longer present",
]
expected_output = [
"!!!! DEPRECATED FLOW (please remove): manage attentive posture",
"!!!! DEPRECATED FLOW (please remove): track user presence state",
"!!!! DEPRECATED FLOW (please remove): user became no longer present",
]
assert convert_colang_2alpha_syntax(input_lines) == expected_output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description