Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev segment in version specifier joined properly #482

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

terrykong
Copy link
Collaborator

@terrykong terrykong commented Jan 15, 2025

What does this PR do ?

Instead of 0.6.0rc0.dev we were creating this 0.6.0rc0.d.e.v.0

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@terrykong terrykong requested review from ko3n1g and ashors1 January 15, 2025 20:19
@terrykong terrykong added the Run CICD Set + un-set to retrigger label Jan 15, 2025
@terrykong terrykong merged commit 735c415 into main Jan 16, 2025
22 checks passed
@terrykong terrykong deleted the tk/fix-package-info-version-dev-segment branch January 16, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants