-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introducing the experimental
package and refactoring test structure
#433
Conversation
experimental
package and refactoring test structure
446bad7
to
2d58504
Compare
@ko3n1g Tried excluding the test files via Manifest.in/exclude_package_data, but both don't seem to work when building a sdist wheel or simply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me, just a few questions below, and one suggestion: I think it'd be better to have tests of experimental features under a dedicated folder, so that we can easily identify them. Either under tests/functional/experimental
, or tests/experimental
, or tests/functional_experimental
for instance.
@odelalleau Makes sense! Please see 2893053 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@odelalleau Makes sense! Please see 2893053
Looking good, thanks!
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: NeMo-Aligner CI <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
aba6608
to
36bd74e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great change, thanks!
What does this PR do ?
Introduces experimental directory structure for code and docs. As part of the restructuring, the tests are moved closer to the source to reduce the repetition of directory structure.
Before
Proposal
these can be filtered out when we publish to pypi(Needs more investigation)