Skip to content

Commit

Permalink
ALSA: hda: cs35l41: Component should be unbound before deconstruction
Browse files Browse the repository at this point in the history
BugLink: https://bugs.launchpad.net/bugs/2075154

[ Upstream commit 6f9a40d ]

The interface associated with the hda_component should be deactivated
before the driver is deconstructed during removal.

Fixes: 7b2f3eb ("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems")
Signed-off-by: Simon Trimmer <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Manuel Diewald <[email protected]>
Signed-off-by: Stefan Bader <[email protected]>
Signed-off-by: Roxana Nicolescu <[email protected]>
  • Loading branch information
simontrimmer authored and roxanan1996 committed Aug 13, 2024
1 parent 8430e32 commit e9e0235
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/pci/hda/cs35l41_hda.c
Original file line number Diff line number Diff line change
Expand Up @@ -1857,15 +1857,15 @@ void cs35l41_hda_remove(struct device *dev)
{
struct cs35l41_hda *cs35l41 = dev_get_drvdata(dev);

component_del(cs35l41->dev, &cs35l41_hda_comp_ops);

pm_runtime_get_sync(cs35l41->dev);
pm_runtime_dont_use_autosuspend(cs35l41->dev);
pm_runtime_disable(cs35l41->dev);

if (cs35l41->halo_initialized)
cs35l41_remove_dsp(cs35l41);

component_del(cs35l41->dev, &cs35l41_hda_comp_ops);

acpi_dev_put(cs35l41->dacpi);

pm_runtime_put_noidle(cs35l41->dev);
Expand Down

0 comments on commit e9e0235

Please sign in to comment.