Skip to content

Conversation

@gcunhase
Copy link
Contributor

@gcunhase gcunhase commented Jan 9, 2026

What does this PR do?

Type of change: Bug fix

Overview: This PR fixes an input type mismatch in Resize layers when being converted to FP16.

Usage

$ python -m modelopt.onnx.autocast --onnx_path=$MODEL_NAME.onnx

Testing

Added unittest.

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes
  • Did you write any new necessary tests?: Yes
  • Did you add or update any necessary documentation?: No
  • Did you update Changelog?: No

Additional Information

This issue is also fixed by using the standalone type inference logic from #719.

@gcunhase gcunhase requested a review from a team as a code owner January 9, 2026 20:29
@gcunhase gcunhase requested a review from galagam January 9, 2026 20:29
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.63%. Comparing base (7971fff) to head (025b905).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   74.63%   74.63%           
=======================================
  Files         192      192           
  Lines       18992    18992           
=======================================
  Hits        14174    14174           
  Misses       4818     4818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant