-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Port Riva's mel cepstral distortion w/ dynamic time warping notebook #5778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jocelyn Huang <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
blisc
reviewed
Jan 12, 2023
| " Returns:\n", | ||
| " mels: Corresponding mel spectrogram.\n", | ||
| " \"\"\"\n", | ||
| " wav_, _ = librosa.load(filename) # load() returns an (audio data, sample rate) tuple\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to pass sr to librosa otherwise it auto resamples to 22050
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Jason <[email protected]> Signed-off-by: Jocelyn <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
blisc
approved these changes
Jan 13, 2023
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
…VIDIA-NeMo#5778) * Port and update Riva MCD DTW tutorial to NeMo TTS tutorials Signed-off-by: Jocelyn Huang <[email protected]> * Add audio files for the MCD DTW notebook Signed-off-by: Jocelyn Huang <[email protected]> * Moved MCD DTW examples to tarball, added add'l resources section Signed-off-by: Jocelyn Huang <[email protected]> * Fix wget link for MCD DTW notebook Signed-off-by: Jocelyn Huang <[email protected]> * Rework audio playing Signed-off-by: Jocelyn Huang <[email protected]> * Typo fixes to MCD DTW notebook Co-authored-by: Jason <[email protected]> Signed-off-by: Jocelyn <[email protected]> * Pass sample rate to librosa load Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Jocelyn <[email protected]> Co-authored-by: Jason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Ports the Riva Mel Cepstral Distortion - Dynamic Time Warping notebook (nvidia-riva/tutorials#96) to NeMo.
HTML version here for ease of viewing:
https://drive.google.com/file/d/1E7bk95HQXZE_LyCfryr1r9LEKPzm8J9D/view?usp=sharing
Collection: TTS
Changelog
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.