[Draft] [TTS] Evaluation: Batch the ASR; refactor for parallelization#15417
Draft
rfejgin wants to merge 20 commits intoNVIDIA-NeMo:mainfrom
Draft
[Draft] [TTS] Evaluation: Batch the ASR; refactor for parallelization#15417rfejgin wants to merge 20 commits intoNVIDIA-NeMo:mainfrom
rfejgin wants to merge 20 commits intoNVIDIA-NeMo:mainfrom
Conversation
For debugging NeMo Skills deployment Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
When running the project from a directory different from the repo root (which happens in NeMo Skills), these paths need to be converted to absolute paths, which is done in this commit. Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
… in Nemo Skills) Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nemo/collections/tts/modules/magpietts_inference/evaluate_generated_audio.py
Fixed
Show fixed
Hide fixed
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
It has been moved outside of evaluate() since in the NeMo Skills use case we need the full metrics for chunk-wise scoring and aggregation at the end. Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
rfejgin
changed the title
rfejgin
changed the title
rfejgin
changed the title
- Break evaluation into two steps: - evaluate_dir() for directory-level evaluation. Can be run in parallel across multiple directories (e.g. in NeMo Skills) - compute_global_metrics() for global metrics aggregation. - Move model loading to separate function - Cleanup Signed-off-by: Fejgin, Roy <rfejgin@nvidia.com>
rfejgin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.