feat: enable timestamp support for batched beam search in RNN-T and TDT#15411
Open
pherber3 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
feat: enable timestamp support for batched beam search in RNN-T and TDT#15411pherber3 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
pherber3 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
Signed-off-by: Patrick Herbert <pherbert@gohealth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Enable
compute_timestamps=Truefor MALSD batch and MAES batch beam search strategies in RNN-T and TDT models (such as parakeet v3). Previously, these strategies raisedNotImplementedError("Preserve alignments is not supported"), blocking timestamp generation even though the beam search infrastructure already tracks timestamp data internally viaBatchedBeamHyps.Collection: ASR
Changelog
NotImplementedErrorwith a warning inModifiedALSDBatchedRNNTComputer,ModifiedALSDBatchedTDTComputer, andModifiedAESBatchedRNNTComputer. Full alignment logprobs are unavailable in beam search, but timestamps are.token_durationstensor toBatchedBeamHypsfor TDT models so_compute_offsets_tdt()receives both start-frame timestamps and per-token durations.Hypothesis.token_durationinto_hyps_list()andto_nbest_hyps_list()for TDT.'malsd_batch'and'maes_batch'to the beam strategy lists forpreserve_alignments/compute_timestampsconfig resolution inRNNTDecoding.Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
@nithinraok - Tagging according to above guidelines for ASR-related changes
Additional Information
model.transcribe(timestamps=True)withmalsd_batchstrategy that it wasn't supported even though the capabilities are there under the hood I believe.stt_en_conformer_transducer_small(RNN-T) andnvidia/stt_en_fastconformer_tdt_large(TDT).nvidia/parakeet-tdt-0.6b-v3usingmalsd_batch+ GPU-PB phrase boosting + NGPU-LM shallow fusion trained using the kenlm script. Timestamps are generated correctly and match the greedy decoder's segment/word boundaries.malsd_batchwith high LM weights (e.g.,ngram_lm_alpha=0.75) can cause content dropout on long audio where segments of speech get skipped entirely. I believe this is a pre-existing beam pruning interaction with LM scoring, not related to this PR's changes. Lower LM weights (0.2), greedy decoding with the same LM, or just using the phrase boosting alone do not exhibit this behavior.tdt_maes_batched_computer.pydoes not exist). If that is made then this should support it but until then TDT models would only be supported with MALSD.