feat(slurm): Add exclusive flag to the Slurm executor #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fgalko <[email protected]>
fgalko-oss
changed the title
fgalko-oss
changed the title
marta-sd
reviewed
Oct 20, 2025
There was a problem hiding this comment.
@fgalko-oss please also add this flag to the defaults in the config and list it in the docs
|
As discussed offline, we'll close this for now. This change can cause a few hard to detect bugs. in short: when you do not have the exclusive flag, 2 benchmarks can be scheduled on the same node and requests can go to the wrong server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.