Use DataDesigner native resume for retrieval SDG#51
Merged
Conversation
eric-tramel
reviewed
Jun 2, 2026
Contributor
eric-tramel
left a comment
There was a problem hiding this comment.
Inline review comments for the issues from the review-nuke pass.
eric-tramel
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
data-designer-retrieval-sdgto use DataDesigner native resumable generation instead of the plugin's manual per-batch restart loop.The
generatecommand now:data-designer>=0.6.1.DataDesigner.create(...)once across the full seed range.--resume/-r {never,always,if_possible}and passes the selectedResumeMode.--dataset-namesupport, with validation before the name is handed to DataDesigner.--buffer-size.The converter keeps backward compatibility for legacy
generated_batch*.jsonoutputs while also accepting.jsonl,.json, and.parquetfiles.Review follow-ups in the latest commit:
.,.., separators, control characters, and names that resolve outside--artifact-path.python-multipartandurllib3.main()and assert export usesresult.artifact_storage.resolved_dataset_name.create()returns, so--buffer-sizeis checkpoint granularity rather than a final peak-memory cap.Why
DataDesigner 0.6.x owns interrupted-run checkpointing now. Keeping plugin-level
--batch-size,--start-batch-index, and--end-batch-indexwould leave two competing restart systems and make resume behavior harder to reason about.This PR makes DataDesigner artifacts the source of truth for resume, while
--output-dirremains the downstream exported JSONL location.Usage
Resume an interrupted run with the same artifact path, dataset name, config, and buffer size:
Convert the exported JSONL:
How
The CLI builds the QA pipeline once using the full discovered seed range and calls
create(..., num_records=total_records, dataset_name=..., resume=...).dd.RunConfig(disable_early_shutdown=True, buffer_size=...)controls DataDesigner checkpoint granularity. The old manual batch JSON writer was removed fromgenerate, but the converter still recognizes legacy batch JSON for existing outputs.The embedding-dedup scheduler test was updated for DataDesigner 0.6.1's model scheduling metadata API, replacing the old
is_llm_boundassertion withget_scheduling_metadata()coverage.The workspace declares
pytestexplicitly in the root dev dependency group somake testdoes not depend on a transitive test dependency from another tool.Validation
Local checks:
UV_CACHE_DIR=/private/tmp/uv-cache make syncUV_CACHE_DIR=/private/tmp/uv-cache make lintUV_CACHE_DIR=/private/tmp/uv-cache uv run pytest plugins/data-designer-retrieval-sdg/tests/test_cli.py plugins/data-designer-retrieval-sdg/tests/test_convert.py(30 passed)UV_CACHE_DIR=/private/tmp/uv-cache make test-plugin PLUGIN=data-designer-retrieval-sdg(78 passed)UV_CACHE_DIR=/private/tmp/uv-cache make validateUV_CACHE_DIR=/private/tmp/uv-cache make checkReal resume smoke against DataDesigner 0.6.1:
/Users/sthan/workspace/retriever-sdg-v3/examples/nv_pp_random--num-files 2 --buffer-size 1 --resume neverparquet-files/batch_00000.parquetand partialtmp-partial-parquet-files/batch_00001.parquet--resume alwaysResuming from batch 2 of 2 (1 records already generated).batch_00000.parquetandbatch_00001.parquetbuild-nvidia/nvidia/corrdiff.txt, thendli/course-v1:DLI+C-FX-01+V3.txt