Standardize Stage Naming: Enforce snake_case with centralized conversion function #1038

Copilot · 2025-09-05T22:11:25Z

All stage naming standardization work is complete with proper validation, comprehensive testing, clean code that passes linting checks, and centralized naming function that eliminates duplication across the codebase.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

copy-pr-bot · 2025-09-05T22:11:29Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Co-authored-by: VibhuJawa <[email protected]>

… naming Co-authored-by: VibhuJawa <[email protected]>

Co-authored-by: VibhuJawa <[email protected]>

VibhuJawa · 2025-09-05T22:46:22Z

@copilot , Please fix these ruff issues.

Error: nemo_curator/stages/base.py:37:1: W293 Blank line contains whitespace
Error: nemo_curator/stages/base.py:40:1: W293 Blank line contains whitespace
Error: nemo_curator/stages/base.py:45:26: EM102 Exception must not use an f-string literal, assign to variable first
Error: tests/stages/test_base.py:529:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:533:42: W291 Trailing whitespace
Error: tests/stages/test_base.py:542:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:545:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:560:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:568:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:572:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:582:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:590:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:595:26: W291 Trailing whitespace
Error: tests/stages/test_base.py:598:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:600:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:607:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:616:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:619:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:621:9: F841 Local variable `invalid_edge_cases` is assigned to but never used
Error: tests/stages/test_base.py:628:1: W293 Blank line contains whitespace
Error: tests/stages/test_base.py:636:1: W293 Blank line contains whitespace
Error: The process '/opt/hostedtoolcache/ruff/0.11.4/x86_64/ruff' failed with exit code 1

…ring exception Co-authored-by: VibhuJawa <[email protected]>

Copilot · 2025-09-05T22:49:56Z

@copilot , Please fix these ruff issues.

...

Fixed all the ruff issues in commit eee822f:

Removed whitespace from blank lines (W293)
Removed trailing whitespace (W291)
Fixed f-string exception by assigning to variable first (EM102)
Removed unused variable (F841)

All the specific error types mentioned are now resolved.

VibhuJawa · 2025-09-05T23:15:49Z

/ok to test 14ca3d9

VibhuJawa

Mostly looks good to me, @ayushdg can you take at the test for me please

VibhuJawa · 2025-09-05T23:18:15Z

tests/stages/deduplication/fuzzy/test_fuzzy_workflow.py

+        assert not (cache_path / "connected_components_stage").exists()
+        assert not (cache_path / "buckets_to_edges_stage").exists()


@ayushdg , Can you check this test please

sarahyurick · 2025-09-05T23:18:44Z

nemo_curator/stages/deduplication/fuzzy/minhash.py

    ):
        # Set ProcessingStage attributes
-        self._name = self.__class__.__name__
+        self._name = "min_hash_stage"


Suggested change

self._name = "min_hash_stage"

self._name = "minhash_stage"

?

@copilot , please address

Fixed in commit 0274d6d. Changed the minhash stage name from "min_hash_stage" to "minhash_stage" as suggested.

Co-authored-by: VibhuJawa <[email protected]>

VibhuJawa · 2025-09-06T00:13:26Z

@copilot , please fix below ruff issues:

Error: nemo_curator/stages/base.py:51:1: W293 Blank line contains whitespace
Error: nemo_curator/stages/base.py:54:1: W293 Blank line contains whitespace
Error: The process '/opt/hostedtoolcache/ruff/0.11.4/x86_64/ruff' failed with exit code 1

Co-authored-by: VibhuJawa <[email protected]>

Copilot · 2025-09-06T00:16:02Z

@copilot , please fix below ruff issues:
Error: nemo_curator/stages/base.py:51:1: W293 Blank line contains whitespace

...

Fixed the ruff W293 issues in commit 41ccb36. Removed whitespace from blank lines 51 and 54 in the _camel_to_snake function docstring.

VibhuJawa · 2025-09-06T01:03:05Z

/okay to test 41ccb36

VibhuJawa · 2025-09-06T03:52:09Z

@copilot , Please fix :

=================================== FAILURES ===================================
______________________ TestPreviewStage.test_with_method _______________________

self = <tests.stages.video.preview.test_preview.TestPreviewStage object at 0x7fd79f1feec0>

    def test_with_method(self):
        """Test the with_ method for creating modified instances."""
        stage = PreviewStage()
    
        # Test modifying parameters that are supported by the base class
        new_stage = stage.with_(name="custom_preview_stage", resources=Resources(cpus=8.0), batch_size=5)
    
        # Verify new instance has modified values
        assert new_stage.name == "custom_preview_stage"
        assert new_stage.resources == Resources(cpus=8.0)
        assert new_stage.batch_size == 5
    
        # Verify original instance is unchanged
>       assert stage.name == "ProcessingStage"  # Default name from base class
E       AssertionError: assert 'processing_stage' == 'ProcessingStage'
E         
E         - ProcessingStage
E         ? ^         ^
E         + processing_stage
E         ? ^         ^^

…and update test expectations Co-authored-by: VibhuJawa <[email protected]>

Copilot · 2025-09-06T03:59:24Z

@copilot , Please fix :

...

Fixed the PreviewStage test failure in commit 25cb9d0. The issue was that PreviewStage wasn't setting its name properly during initialization. Updated it to use the centralized _camel_to_snake function and fixed the test expectation to check for "preview_stage" instead of "ProcessingStage".

VibhuJawa · 2025-09-08T18:05:08Z

/okay to test d3e4dbd

VibhuJawa · 2025-09-09T17:39:19Z

/ok to test 0cd716b

Initial plan

1880f08

Copilot AI assigned Copilot and VibhuJawa Sep 5, 2025

Copilot started work on behalf of VibhuJawa September 5, 2025 22:11 View session

github-actions bot added the community-request label Sep 5, 2025

Copilot AI and others added 4 commits September 5, 2025 22:21

Convert all stage names from CamelCase to snake_case

1dd4b3e

Co-authored-by: VibhuJawa <[email protected]>

Add comprehensive stage naming validation tests and fix existing test…

6645b7e

… naming Co-authored-by: VibhuJawa <[email protected]>

Fix test references to use new snake_case stage names

bf192b8

Co-authored-by: VibhuJawa <[email protected]>

Complete stage naming standardization with documentation update

eee822f

Co-authored-by: VibhuJawa <[email protected]>

Copilot AI changed the title ~~[WIP] [IMP] Standardize Stage Naming (CamelCase classes, snake_case identifiers)~~ Standardize Stage Naming: Enforce snake_case for stage identifiers Sep 5, 2025

Copilot finished work on behalf of VibhuJawa September 5, 2025 22:35

Copilot AI requested a review from VibhuJawa September 5, 2025 22:35

VibhuJawa marked this pull request as ready for review September 5, 2025 22:45

VibhuJawa requested review from ayushdg and praateekmahajan September 5, 2025 22:45

Copilot started work on behalf of VibhuJawa September 5, 2025 22:46 View session

Fix ruff linting issues: remove whitespace, trailing spaces, fix f-st…

14ca3d9

…ring exception Co-authored-by: VibhuJawa <[email protected]>

Copilot finished work on behalf of VibhuJawa September 5, 2025 22:50

VibhuJawa enabled auto-merge (squash) September 5, 2025 22:58

VibhuJawa requested a review from sarahyurick September 5, 2025 23:15

copy-pr-bot bot temporarily deployed to test September 5, 2025 23:16 Inactive

copy-pr-bot bot had a problem deploying to nemo-ci September 5, 2025 23:16 Failure

VibhuJawa reviewed Sep 5, 2025

View reviewed changes

sarahyurick reviewed Sep 5, 2025

View reviewed changes

sarahyurick added the r1.0.0 Pick this label for auto cherry-picking into r1.0.0 label Sep 5, 2025

Copilot AI changed the title ~~Standardize Stage Naming: Enforce snake_case for stage identifiers~~ Standardize Stage Naming: Enforce snake_case with centralized conversion function Sep 6, 2025

Copilot finished work on behalf of VibhuJawa September 6, 2025 00:07

Copilot started work on behalf of VibhuJawa September 6, 2025 00:07 View session

Fix minhash stage name: change "min_hash_stage" to "minhash_stage"

0274d6d

Co-authored-by: VibhuJawa <[email protected]>

Copilot finished work on behalf of VibhuJawa September 6, 2025 00:11

Copilot started work on behalf of VibhuJawa September 6, 2025 00:13 View session

Fix ruff W293 issues: Remove whitespace from blank lines in docstring

41ccb36

Co-authored-by: VibhuJawa <[email protected]>

Copilot finished work on behalf of VibhuJawa September 6, 2025 00:16

copy-pr-bot bot temporarily deployed to test September 6, 2025 01:03 Inactive

copy-pr-bot bot had a problem deploying to nemo-ci September 6, 2025 01:03 Failure

Copilot started work on behalf of VibhuJawa September 6, 2025 03:52 View session

Fix PreviewStage naming: set proper snake_case name in __post_init__ …

25cb9d0

…and update test expectations Co-authored-by: VibhuJawa <[email protected]>

Copilot finished work on behalf of VibhuJawa September 6, 2025 04:00

Merge branch 'main' into copilot/fix-986-2

d3e4dbd

copy-pr-bot bot temporarily deployed to test September 8, 2025 18:05 Inactive

copy-pr-bot bot had a problem deploying to nemo-ci September 8, 2025 18:05 Failure

copy-pr-bot bot temporarily deployed to nemo-ci September 8, 2025 18:05 Inactive

Merge branch 'main' into copilot/fix-986-2

0cd716b

copy-pr-bot bot temporarily deployed to test September 9, 2025 17:39 Inactive

copy-pr-bot bot temporarily deployed to nemo-ci September 9, 2025 17:39 Inactive

copy-pr-bot bot had a problem deploying to nemo-ci September 9, 2025 17:54 Failure

		assert not (cache_path / "connected_components_stage").exists()
		assert not (cache_path / "buckets_to_edges_stage").exists()

Standardize Stage Naming: Enforce snake_case with centralized conversion function #1038

Are you sure you want to change the base?

Standardize Stage Naming: Enforce snake_case with centralized conversion function #1038

Uh oh!

Conversation

Copilot AI commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot bot commented Sep 5, 2025

Uh oh!

VibhuJawa commented Sep 5, 2025

Uh oh!

Copilot AI commented Sep 5, 2025

Uh oh!

VibhuJawa commented Sep 5, 2025

Uh oh!

VibhuJawa left a comment

Choose a reason for hiding this comment

Uh oh!

VibhuJawa Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

sarahyurick Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

VibhuJawa Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

VibhuJawa commented Sep 6, 2025

Uh oh!

Copilot AI commented Sep 6, 2025

Uh oh!

VibhuJawa commented Sep 6, 2025

Uh oh!

VibhuJawa commented Sep 6, 2025

Uh oh!

Copilot AI commented Sep 6, 2025

Uh oh!

VibhuJawa commented Sep 8, 2025

Uh oh!

VibhuJawa commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 5, 2025 •

edited

Loading