Bumped tbd to 3.4.2 to update json-schema. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyikuang
force-pushed
the
update_tbd
branch
4 times, most recently
from
efbea30 to
d770841
Compare
wenyikuang
force-pushed
the
update_tbd
branch
from
d770841 to
b37963b
Compare
This was referenced Sep 24, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/urbanopt/urbanopt-geojson-gem/blob/develop/lib/urbanopt/geojson/feature.rb#L285
And
https://github.com/urbanopt/urbanopt-geojson-gem/blob/develop/lib/urbanopt/geojson/geo_file.rb#L223
Is using the json-schema from OS-gems
And the OS-gems is using the json-schema from tbd, which should be and has been updated from Juliens' PR:
#95
Something further todo:
https://github.com/NREL/OpenStudio/blob/ba1b94b6542c1f1d4cdcdb775886852b9a82bc4f/ruby/bindings/InitRubyBindings.cpp#L474
Remove the require stringio in Openstudio.
Related issue:
NREL/OpenStudio#4969 (From Openstudio side)
urbanopt/urbanopt-core-gem#59 (To use os3.8 with Ruby3)