Fix #10902 - CoolingTower:VariableSpeed:Merkel not reporting to Equipment Summary - Cooling Towers and Fluid Coolers

[jmarrec]

Pull request overview

• Fixes CoolingTower:VariableSpeed:Merkel not reporting to Equipment Summary - Cooling Towers and Fluid Coolers #10902

Description of the purpose of this PR

CoolingTower:VariableSpeed:Merkel not reporting to Equipment Summary - Cooling Towers and Fluid Coolers

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[jmarrec]

Add a unit test for #10902 showing that it CoolingTower:VariableSpeed:Merkel is not reported to Equipment Summary - Cooling Towers and Fluid Coolers

[jmarrec]

1001: [ RUN      ] EnergyPlusFixture.CondenserLoopTowers_VSMerkelCoolingTower_OutputReport
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5410: Failure
1001: Expected equality of these values:
1001:   "CoolingTower:VariableSpeed:Merkel"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCType, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5411: Failure
1001: Expected equality of these values:
1001:   "WATER"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCFluidType, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5412: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesingRange)
1001:     Which is: "6.14"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCRange, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5413: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesingApproach)
1001:     Which is: "4.56"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCApproach, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5415: Failure
1001: Expected equality of these values:
1001:   "4000.00"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesFanPwr, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5416: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesignInletWB)
1001:     Which is: "25.70"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesInletAirWBT, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5418: Failure
1001: Expected equality of these values:
1001:   "0.020000"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesWaterFlowRate, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5419: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesOutletWaterTemp)
1001:     Which is: "30.26"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCLevWaterSPTemp, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5421: Failure
1001: Expected equality of these values:
1001:   "COOLINGTOWER LOOP"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCCondLoopName, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5422: Failure
1001: Expected equality of these values:
1001:   "COOLINGTOWER SUPPLY EQUIPMENT BRANCH 1"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCCondLoopBranchName, TowerName)
1001:     Which is: "NOT FOUND"
1001: [  FAILED  ] EnergyPlusFixture.CondenserLoopTowers_VSMerkelCoolingTower_OutputReport (2392 ms)

[jmarrec]

cf https://myoldmopar.github.io/EnergyPlusBuildResults/EnergyPlus-643795708957dbce5adc9830a52414e02960b382-x86_64-Linux-Ubuntu-24.04-gcc-13.3.html

[github-actions]

⚠️ Regressions detected on macos-14 for commit 60e5327

Regression Summary

• Audit: 1

• View Results
• Download Regressions

[Myoldmopar]

This seems fine here. My only wish is that we could have reused an existing implementation of this logic. I'm sure there are so many spots where this is written very similarly. But maybe it's different enough that reusing it would be a net loss. Anyway, it's fine as is.

[Myoldmopar]

This does seem ready for final checks/merge, right @jmarrec ?

[jmarrec]

Yes

[Myoldmopar]

Running great here with latest develop, good to go. Thanks @jmarrec