Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoolingTower:VariableSpeed:Merkel not reporting to Equipment Summary - Cooling Towers and Fluid Coolers #10902

Open
3 tasks
jmarrec opened this issue Jan 21, 2025 · 0 comments · May be fixed by #10930
Open
3 tasks

CoolingTower:VariableSpeed:Merkel not reporting to Equipment Summary - Cooling Towers and Fluid Coolers #10902

jmarrec opened this issue Jan 21, 2025 · 0 comments · May be fixed by #10930
Assignees
@jmarrec
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@jmarrec
Copy link
Contributor

jmarrec commented Jan 21, 2025

Issue overview

CoolingTower:VariableSpeed:Merkel is not reporting to Equipment Summary - Cooling Towers and Fluid Coolers

Take CoolingTower_MerkelVariableSpeed.idf from testfiles/

Image

Details

Some additional details for this issue (if relevant):

  • Platform: All
  • Version of EnergyPlus: Latest develop, 31e3c33

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to EnergyPlus Defect Complexity (Github Project)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@jmarrec jmarrec added the Defect Includes code to repair a defect in EnergyPlus label Jan 21, 2025
@jmarrec jmarrec self-assigned this Jan 21, 2025
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Feb 6, 2025
@jmarrec
Add a unit test for NREL#10902 showing that it CoolingTower:VariableS…
ee606a7 
…peed:Merkel is not reported to Equipment Summary - Cooling Towers and Fluid Coolers

```
[ RUN      ] EnergyPlusFixture.CondenserLoopTowers_VSMerkelCoolingTower_OutputReport
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5487: Failure
Expected equality of these values:
  "CoolingTower:VariableSpeed:Merkel"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCType, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5488: Failure
Expected equality of these values:
  "WATER"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCFluidType, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5489: Failure
Expected equality of these values:
  fmt::format("{:.2f}", expectedDesingRange)
    Which is: "6.14"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCRange, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5490: Failure
Expected equality of these values:
  fmt::format("{:.2f}", expectedDesingApproach)
    Which is: "4.56"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCApproach, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5492: Failure
Expected equality of these values:
  "4000.00"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesFanPwr, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5493: Failure
Expected equality of these values:
  fmt::format("{:.2f}", expectedDesignInletWB)
    Which is: "25.70"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesInletAirWBT, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5495: Failure
Expected equality of these values:
  "0.020000"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesWaterFlowRate, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5496: Failure
Expected equality of these values:
  fmt::format("{:.2f}", expectedDesOutletWaterTemp)
    Which is: "30.26"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCLevWaterSPTemp, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5498: Failure
Expected equality of these values:
  "COOLINGTOWER LOOP"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCCondLoopName, TowerName)
    Which is: "NOT FOUND"
/home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5499: Failure
Expected equality of these values:
  "COOLINGTOWER SUPPLY EQUIPMENT BRANCH 1"
  OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCCondLoopBranchName, TowerName)
    Which is: "NOT FOUND"
[  FAILED  ] EnergyPlusFixture.CondenserLoopTowers_VSMerkelCoolingTower_OutputReport (268 ms)
```
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Feb 6, 2025
@jmarrec
Fix NREL#10902 - Report CoolingTower:VariableSpeed:Merkel to Equipmen…
0017a05 
…t Summary
jmarrec added a commit to jmarrec/EnergyPlus that referenced this issue Feb 10, 2025
@jmarrec
Add a unit test for NREL#10902 showing that it CoolingTower:VariableS…
6437957 
…peed:Merkel is not reported to Equipment Summary - Cooling Towers and Fluid Coolers

```
1001: [ RUN      ] EnergyPlusFixture.CondenserLoopTowers_VSMerkelCoolingTower_OutputReport
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5410: Failure
1001: Expected equality of these values:
1001:   "CoolingTower:VariableSpeed:Merkel"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCType, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5411: Failure
1001: Expected equality of these values:
1001:   "WATER"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCFluidType, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5412: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesingRange)
1001:     Which is: "6.14"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCRange, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5413: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesingApproach)
1001:     Which is: "4.56"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCApproach, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5415: Failure
1001: Expected equality of these values:
1001:   "4000.00"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesFanPwr, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5416: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesignInletWB)
1001:     Which is: "25.70"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesInletAirWBT, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5418: Failure
1001: Expected equality of these values:
1001:   "0.020000"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCDesWaterFlowRate, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5419: Failure
1001: Expected equality of these values:
1001:   fmt::format("{:.2f}", expectedDesOutletWaterTemp)
1001:     Which is: "30.26"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCLevWaterSPTemp, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5421: Failure
1001: Expected equality of these values:
1001:   "COOLINGTOWER LOOP"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCCondLoopName, TowerName)
1001:     Which is: "NOT FOUND"
1001: /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/CondenserLoopTowers.unit.cc:5422: Failure
1001: Expected equality of these values:
1001:   "COOLINGTOWER SUPPLY EQUIPMENT BRANCH 1"
1001:   OutputReportPredefined::RetrievePreDefTableEntry(*state, orp.pdchCTFCCondLoopBranchName, TowerName)
1001:     Which is: "NOT FOUND"
1001: [  FAILED  ] EnergyPlusFixture.CondenserLoopTowers_VSMerkelCoolingTower_OutputReport (2392 ms)
```
@jmarrec jmarrec linked a pull request Feb 10, 2025 that will close this issue
Open
20 tasks
jmarrec added a commit that referenced this issue Feb 10, 2025
@jmarrec
Fix #10902 - Report CoolingTower:VariableSpeed:Merkel to Equipment Su…
e66ad5a 
…mmary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
1 participant
@jmarrec