Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Specify Tracer Advection Time Step #757

Open
wants to merge 5 commits into
base: dev/gfdl
Choose a base branch
from
Open

Add Option to Specify Tracer Advection Time Step #757

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97c9aeb
Add option to set tracer advection timestep
Oct 23, 2024
e13b134
Add error warning if diabatic_first is true
Nov 20, 2024
9bd5340
Change variable, add do advection before thermo step
Nov 27, 2024
d1f89fb
Merge branch 'dev/gfdl' into add_dt_tadvect
Hallberg-NOAA Nov 30, 2024
a31efd1
Add logic to do_diabatic check
Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/core/MOM.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,10 +962,12 @@ subroutine step_MOM(forces_in, fluxes_in, sfc_state, Time_start, time_int_in, CS

!===========================================================================
! This is the second place where the diabatic processes and remapping could occur.
if (thermo_does_span_coupling .or. .not.do_dyn) then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now appears that there are cases where do_diabatic is not being initialized, but it is being used on line 972. Logically the value of do_diabatic does not matter, but the use of an uninitialized variable will be flagged when certain debugging capabilities are enabled. Please consider adding else ; do_diabatic = .false. just before line 971.

do_diabatic = (CS%t_dyn_rel_thermo + 0.5*dt > dt_therm)
else
do_diabatic = ((MOD(n,ntstep) == 0) .or. (n==n_max))
if (do_thermo) then
if (thermo_does_span_coupling .or. .not.do_dyn) then
do_diabatic = (CS%t_dyn_rel_thermo + 0.5*dt > dt_therm)
else
do_diabatic = ((MOD(n,ntstep) == 0) .or. (n==n_max))
endif
endif
if ((CS%t_dyn_rel_adv==0.0) .and. do_thermo .and. (.not.CS%diabatic_first) .and. do_diabatic) then

Expand Down
Loading