added files to the repo #22
Conversation
rmclaren
requested review from
emilyhcliu,
ilianagenkova,
PraveenKumar-NOAA and
rmclaren
| query: '*/WS10' | ||
|
|
||
| # Total Number (with respect to accumulation or average) | ||
| TotalNumber: |
There was a problem hiding this comment.
inconsistent nameing, start with lower case
There was a problem hiding this comment.
use Camel case, i.e. "totalNumber"
There was a problem hiding this comment.
I've made that change. Thanks!
| query: '*/ACAV' | ||
|
|
||
| #BackScatter Distance | ||
| BackScatterDistance: |
There was a problem hiding this comment.
I've made that change. Thanks!
| query: '*/BSCD' | ||
|
|
||
| #Likelihood computed for solution | ||
| LikelihoodComputedForSolution: |
bufr2ioda_satwnd_amv_goes.py
Outdated
| # { | ||
| # 'name': 'windSpeed', | ||
| # 'source': 'variables/windSpeed', | ||
| # 'units': 'm/s', | ||
| # 'longName': 'Eastward Wind Component', | ||
| # }, | ||
| # { | ||
| # 'name': 'windSpeed', | ||
| # 'source': 'variables/windSpeed', | ||
| # 'units': 'm/s', | ||
| # 'longName': 'Northward Wind Component', | ||
| # }, |
There was a problem hiding this comment.
remove all commented code
There was a problem hiding this comment.
Thanks, I removed that commented code section and will do others.
bufr2ioda_satwnd_amv_goes.py
Outdated
| if satid.size == 0: | ||
| logging(comm, 'WARNING', f'category {cat[0]} does not exist in input file') | ||
| #paths = container.get_paths('variables/windDirection', cat) | ||
| #obstype = container.get('variables/windComputationMethod', cat) | ||
| #container.add('variables/obstype_uwind', obstype, paths, cat) | ||
| #container.add('variables/obstype_vwind', obstype, paths, cat) | ||
|
|
||
| #paths = container.get_paths('variables/windSpeed', cat) | ||
| #wsp10 = container.get('variables/windSpeed', cat) | ||
| #container.add('variables/windSpeed', wsp10, paths, cat) | ||
| # container.add('variables/windEastward', wob, paths, cat) | ||
| # container.add('variables/windNorthward', wob, paths, cat) | ||
| # print('##################################') | ||
| # print(wob) | ||
|
|
||
|
|
||
|
|
||
|
|
||
| else: | ||
| print('more stuff to be added here') | ||
| # Add new variables: ObsType/windEastward & ObsType/windNorthward | ||
| #swcm = container.get('variables/windComputationMethod', cat) | ||
| #paths = container.get_paths('variables/windSpeed', cat) | ||
| #windDirection = container.get('variables/windDirection', cat) | ||
| #windSpeed = container.get('variables/windSpeed', cat) | ||
| #uob, vob = compute_wind_components(windDirection, windSpeed) | ||
| #container.add('variables/windEastward', uob, paths, cat) | ||
| #container.add('variables/windNorthward', vob, paths, cat) | ||
|
|
||
|
|
||
|
|
||
|
|
||
| #chanfreq = container.get('variables/sensorCentralFrequency', cat) | ||
|
|
||
| #logging(comm, 'DEBUG', f'swcm min/max = {swcm.min()} {swcm.max()}') | ||
| #logging(comm, 'DEBUG', f'chanfreq min/max = {chanfreq.min()} {chanfreq.max()}') | ||
|
|
||
| #obstype = _get_obs_type(swcm, chanfreq) | ||
|
|
||
| #logging(comm, 'DEBUG', f'obstype = {obstype}') | ||
| #logging(comm, 'DEBUG', f'obstype min/max = {obstype.min()} {obstype.max()}') | ||
|
|
||
| #paths = container.get_paths('variables/windComputationMethod', cat) | ||
| #container.add('variables/obstype_uwind', obstype, paths, cat) | ||
| #container.add('variables/obstype_vwind', obstype, paths, cat) | ||
|
|
||
| # Add new variables: ObsValue/windEastward & ObsValue/windNorthward | ||
| #wdir = container.get('variables/windDirection', cat) | ||
| #wspd = container.get('variables/windSpeed', cat) | ||
|
|
||
| #logging(comm, 'DEBUG', f'wdir min/max = {wdir.min()} {wdir.max()}') | ||
| #logging(comm, 'DEBUG', f'wspd min/max = {wspd.min()} {wspd.max()}') | ||
|
|
||
| #uob, vob = compute_wind_components(wdir, wspd) | ||
|
|
||
| #logging(comm, 'DEBUG', f'uob min/max = {uob.min()} {uob.max()}') | ||
| #logging(comm, 'DEBUG', f'vob min/max = {vob.min()} {vob.max()}') | ||
|
|
||
| #paths = container.get_paths('variables/windSpeed', cat) | ||
| #container.add('variables/windEastward', uob, paths, cat) | ||
| #container.add('variables/windNorthward', vob, paths, cat) |
There was a problem hiding this comment.
This code doesn't do anything. "more stuff to add" ??
There was a problem hiding this comment.
I was going to leave it blank as I'm not sure what to do add to this and I know Emily had mentioned just looking at the YAML files and not the python script. I've made all the corrections to the Python file though.
bufr2ioda_satwnd_amv_goes.py
Outdated
| print(len(var_test)) | ||
| print(satid) |
There was a problem hiding this comment.
I removed the print statements. Thanks!
bufr2ioda_satwnd_amv_goes.py
Outdated
| satid = container.get('variables/satelliteId', cat) | ||
| var_test = container.get('variables/windDirection', cat) |
There was a problem hiding this comment.
I removed those variables. Thanks!
There was a problem hiding this comment.
When I remove the satid=... and try running the code; I get an error message stating that satid is not defined and it stops running. I'll leave it in for now.
bufr2ioda_satwnd_amv_goes.py
Outdated
| { | ||
| 'name': 'ObsValue/windDirection', | ||
| 'source': 'variables/windDirection', | ||
| 'units': '1', | ||
| 'longName': 'Observation Type based on Satellite-derived Wind Computation Method and Spectral Band', | ||
| }, | ||
| { | ||
| 'name': 'ObsValue/windSpeed', | ||
| 'source': 'variables/windSpeed', | ||
| 'units': '1', | ||
| 'longName': 'Observation Type based on Satellite-derived Wind Computation Method and Spectral Band', | ||
| }, |
There was a problem hiding this comment.
these are already defined in the YAML file, why need tham here?
There was a problem hiding this comment.
When I comment this section out the python program complains and mentions that it needs "KeyError: 'name'"; I can leave it in for now but I'm open to removing it too.
Emily requested this file be deleted.
|
@JasonWelsh-NOAA Since you do not have Python script in this PR, you will need to drop the `bufr_scrip_backend_ascatw.yaml' test configuration file. What you need is a bufr backend test configuration file. The bufr backend configuration file can be used to test your mapping file in this PR). |
Added files for ascatw converter program in order for a pull request to be completed.