-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nonjcb configuration builder #630
base: rrfs-mpas-jedi
Are you sure you want to change the base?
Add nonjcb configuration builder #630
Conversation
…xrrfs_jedivar.sh.
@guoqing-noaa, I made a template PR for building the jedivar yaml from the yamls in RDASApp once we sort out the problem with using all the QC filters. I added a tool to generate the yamls (very similar to RDASApp's gen_yaml.sh). I was also wondering if this is supposed to be python instead of bash? |
@delippi Thanks for developing this. |
workflow/gen_jedivar_yaml_nonjcb.sh
Outdated
@@ -0,0 +1,96 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any non-runtime utilities will go to the workflow/ush
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will move it.
-e "s/@HYB_WGT_ENS@/${HYB_WGT_ENS}/" \ | ||
-e "s/@length@/${length}/" \ | ||
-e "s/@DISTRIBUTION@/$distribution/" \ | ||
./jedivar.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here break the existing hybrid settings. i.e. We cannot do pure 3DVAR or pure EnVar after this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean because I removed this part?
- if [[ "${HYB_WGT_ENS}" == "0" ]]; then # pure 3DVAR
- sed -i '88,113d' ./jedivar.yaml
- elif [[ "${HYB_WGT_STATIC}" == "0" ]]; then # pure 3DEnVar
- sed -i '46,87d' ./jedivar.yaml
- fi
We will have (and do have in RDASApp) a 3dvar and pure envar template instead of deleting these sections. You would specify this via
basic_config="mpasjedi_hyb3denvar.yaml"
I figured you would still use that yaml for some time. This is just a draft to get it ready to go when we are ready for it. |
DESCRIPTION OF CHANGES:
workflow/gen_jedivar_yaml_nonjcb.sh
) to build the jedivar.yaml. This is built prior to running the workflow.scripts/exrrfs_jedivar.sh
for using the preconfigured jedivar.yamlTESTS CONDUCTED:
Tested on Hera conus 12km retro runs.
ISSUE: