Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nonjcb configuration builder #630

Draft
wants to merge 2 commits into
base: rrfs-mpas-jedi
Choose a base branch
from

Conversation

delippi
Copy link
Contributor

@delippi delippi commented Feb 10, 2025

DESCRIPTION OF CHANGES:

  • Added a tool (workflow/gen_jedivar_yaml_nonjcb.sh) to build the jedivar.yaml. This is built prior to running the workflow.
  • Minor updates to scripts/exrrfs_jedivar.sh for using the preconfigured jedivar.yaml

TESTS CONDUCTED:

Tested on Hera conus 12km retro runs.

ISSUE:

@delippi
Copy link
Contributor Author

delippi commented Feb 10, 2025

@guoqing-noaa, I made a template PR for building the jedivar yaml from the yamls in RDASApp once we sort out the problem with using all the QC filters. I added a tool to generate the yamls (very similar to RDASApp's gen_yaml.sh). I was also wondering if this is supposed to be python instead of bash?

@guoqing-noaa
Copy link
Contributor

@delippi Thanks for developing this.
However, at this moment, we want to track the jedivar.yaml directly from the parm/ directory.
We still have a lot to go on the workflow side and this is not a top priority at the moment. We may revisit this later. Thanks!

@@ -0,0 +1,96 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any non-runtime utilities will go to the workflow/ush directory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move it.

-e "s/@HYB_WGT_ENS@/${HYB_WGT_ENS}/" \
-e "s/@length@/${length}/" \
-e "s/@DISTRIBUTION@/$distribution/" \
./jedivar.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here break the existing hybrid settings. i.e. We cannot do pure 3DVAR or pure EnVar after this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean because I removed this part?

- if [[ "${HYB_WGT_ENS}" == "0" ]]; then # pure 3DVAR
-   sed -i '88,113d' ./jedivar.yaml
- elif [[ "${HYB_WGT_STATIC}" == "0" ]]; then # pure 3DEnVar
-   sed -i '46,87d' ./jedivar.yaml
- fi

We will have (and do have in RDASApp) a 3dvar and pure envar template instead of deleting these sections. You would specify this via

basic_config="mpasjedi_hyb3denvar.yaml"

@delippi
Copy link
Contributor Author

delippi commented Feb 10, 2025

@delippi Thanks for developing this. However, at this moment, we want to track the jedivar.yaml directly from the parm/ directory. We still have a lot to go on the workflow side and this is not a top priority at the moment. We may revisit this later. Thanks!

I figured you would still use that yaml for some time. This is just a draft to get it ready to go when we are ready for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants