Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of RUNs #3335

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

mingshichen-noaa
Copy link
Contributor

Description

The rocoto workflow currently lists the gdas tasks first, then enkfgdas, then gfs. However, this is reversed from the logical order, where [enkf]gfs is the "early cycle" and [enkf]gdas is the "late cycle".
Refs #3306

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. You moved the RUNs, but not the conditionals attached to them.

@mingshichen-noaa
Copy link
Contributor Author

@WalterKolczynski-NOAA
I will fix out the issue as soon as possible.

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Change the running order as gfs_enkfgfs_gdas_enkfgdas Change order of RUNs Feb 19, 2025
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the pynorms errors

@mingshichen-noaa
Copy link
Contributor Author

@WalterKolczynski-NOAA
Yes, I will fix the pynorms errors as soon as possible. Local tests show one of all tasks is dead.

@mingshichen-noaa
Copy link
Contributor Author

@WalterKolczynski-NOAA
I have fixed the pynorm errors and then doing the PR CI testing again in Hercules.

@WalterKolczynski-NOAA
Copy link
Contributor

@mingshichen-noaa pynorms is still failing

@mingshichen-noaa
Copy link
Contributor Author

@WalterKolczynski-NOAA
I have reviewed the modified codes and have not found any problem. But Check Python coding norms with pycodestyle showed one error. I am still working on the issue. Could you give me some suggestion? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants