Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM #3333

Merged
merged 9 commits into from
Feb 20, 2025
Merged

Update jgdas enkf update job with COMIN or COMOUT prefix instead of COM #3333

merged 9 commits into from
Feb 20, 2025

Conversation

mingshichen-noaa
Copy link
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global JGDAS_ENKF_UPDATE job and associated bash and python scripts

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

KateFriedman-NOAA
KateFriedman-NOAA requested changes Feb 18, 2025
View reviewed changes
KateFriedman-NOAA
KateFriedman-NOAA approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mingshichen-noaa !

@mingshichen-noaa
Copy link
Contributor Author

@KateFriedman-NOAA
CI tests of all tasks are successful in Hercules environments. Please refer to test results at /work2/noaa/global/mchen/test/jobs/JGDAS_ENKF_UPDATE/EXPDIR/C96C48_hybatmDA

@KateFriedman-NOAA
Copy link
Member

@KateFriedman-NOAA CI tests of all tasks are successful in Hercules environments. Please refer to test results at /work2/noaa/global/mchen/test/jobs/JGDAS_ENKF_UPDATE/EXPDIR/C96C48_hybatmDA

Thanks @mingshichen-noaa ! We will begin CI for your branch.

@KateFriedman-NOAA KateFriedman-NOAA added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Feb 19, 2025
@emcbot emcbot added the CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS label Feb 19, 2025
@KateFriedman-NOAA KateFriedman-NOAA removed the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Feb 19, 2025
@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Feb 19, 2025
@emcbot
Copy link

emcbot commented Feb 19, 2025

CI Tests set up to run in /lfs/h2/emc/ptmp/emc.global/PR/PR_3333/RUNTESTS on WCOSS

@KateFriedman-NOAA
Copy link
Member

CI completed successfully on WCOSS2:

Thu Feb 20 17:20:22 UTC 2025
******** C48_ATM_3333 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Feb 19 2025 21:08:42    Feb 19 2025 22:30:32

******** C48_S2SW_3333 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Feb 19 2025 21:08:43    Feb 19 2025 22:30:35

******** C48_S2SWA_gefs_3333 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Feb 19 2025 21:08:47    Feb 19 2025 23:05:33

******** C96_atm3DVar_extended_3333 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Feb 19 2025 21:08:49    Feb 19 2025 21:25:43
202112210000        Done    Feb 19 2025 21:08:49    Feb 20 2025 01:45:35
202112210600        Done    Feb 19 2025 21:08:49    Feb 20 2025 02:30:39
202112211200        Done    Feb 19 2025 21:30:41    Feb 20 2025 03:40:27
202112211800        Done    Feb 20 2025 01:50:26    Feb 20 2025 06:45:38

******** C96C48_hybatmDA_3333 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Feb 19 2025 21:08:51    Feb 19 2025 21:25:49
202112210000        Done    Feb 19 2025 21:08:51    Feb 19 2025 23:20:41
202112210600        Done    Feb 19 2025 21:08:51    Feb 19 2025 23:20:41

@KateFriedman-NOAA KateFriedman-NOAA removed the CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress label Feb 20, 2025
@KateFriedman-NOAA KateFriedman-NOAA added the CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully label Feb 20, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit c902645 into NOAA-EMC:develop Feb 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA

Assignees
No one assigned
Labels
CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mingshichen-noaa @KateFriedman-NOAA @emcbot @WalterKolczynski-NOAA